Add Kotlin exploration tests#11921
Conversation
jpbempel
force-pushed
the
jpbempel/kotlin-exploration-tests
branch
from
0e750fa to
83d262a
Compare
|
🎯 Code Coverage (details) 🔗 Commit SHA: ff19301 | Docs | Datadog PR Page | Give us feedback! |
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 5 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (329.721 µs) : 307, 353
. : milestone, 330,
basic (293.664 µs) : 288, 300
. : milestone, 294,
loop (8.989 ms) : 8984, 8993
. : milestone, 8989,
section candidate
noprobe (338.672 µs) : 308, 370
. : milestone, 339,
basic (298.375 µs) : 292, 305
. : milestone, 298,
loop (8.988 ms) : 8983, 8994
. : milestone, 8988,
|
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
jpbempel
force-pushed
the
jpbempel/kotlin-exploration-tests
branch
3 times, most recently
from
2b3a187 to
719a066
Compare
Bits couldn’t fix the CI🟢 Investigated · 🔴 Fix failed · ⚪ Validate · ⚪ Ready OkHttp exploration jobs were running against prebuilt repository checkouts that could miss branch-provided View in Datadog | Reviewed commit b550046 |
jpbempel
force-pushed
the
jpbempel/kotlin-exploration-tests
branch
from
719a066 to
b550046
Compare
jpbempel
requested review from
PerfectSlayer,
erikayasuda and
ojung
and removed request for
a team
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
use okhttp library with branch 5.3 and instrument all methods from package okhttp3/*
jpbempel
force-pushed
the
jpbempel/kotlin-exploration-tests
branch
from
b550046 to
ff19301
Compare
![datadog-official[bot]](https://avatars.githubusercontent.com/in/1358509?s=60&v=4){kind=small}
There was a problem hiding this comment.
More details
This PR adds OkHttp Kotlin exploration tests with Docker setup, CI configuration, and test patches. All changes are infrastructure-only (CI config, Docker setup, test disabling via patches). No production code is modified. The happy path should execute successfully; exploration test infrastructure is internal, not user-facing.
📊 Validated against 3 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit b550046 · What is Autotest? · Any feedback? Reach out in #autotest
jpbempel
added
comp: debugger
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b550046f5c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| needs: [ build ] | ||
| dependencies: | ||
| - build | ||
| <<: *common-exploration-tests |
There was a problem hiding this comment.
In merge-request pipelines that touch dd-java-agent/agent-debugger, this new job inherits the common changes rule and runs automatically, but the only step that creates /exploration-tests/okhttp is in Dockerfile.exploration-tests and build-exploration-tests-image is still when: manual with no needs edge. The first automatic run of this change will therefore use the already-published $EXPLORATION_TESTS_IMAGE without an OkHttp checkout, causing run-exploration-tests.sh to fail at cd $PROJECT; keep the job manual until the image is published or wire it to an image built in the same pipeline.
Useful? React with 👍 / 👎.
| RUN git clone -b okhttp_5.3.x https://github.com/square/okhttp.git | ||
| COPY okhttp_exploration-tests.patch . | ||
| RUN cd okhttp && git apply /exploration-tests/okhttp_exploration-tests.patch | ||
| RUN bash -c "source $HOME/.sdkman/bin/sdkman-init.sh && sdk use java 17.0.10-tem && cd okhttp && ./gradlew dependencies" |
There was a problem hiding this comment.
The image now configures the cloned OkHttp Gradle build, but this Debian image only installs JDKs/Maven and never provides ANDROID_HOME or local.properties. OkHttp's okhttp module applies the Android library plugin with compileSdk = 35, so project configuration for ./gradlew dependencies/jvmTest requires a valid Android SDK and fails with the usual SDK-location error; install an SDK in the image or disable the Android target before invoking Gradle.
Useful? React with 👍 / 👎.
Bits couldn’t fix the CI🟢 Investigated · 🔴 Fix failed · ⚪ Validate · ⚪ Ready
View in Datadog | Reviewed commit ff19301 |
1 participant
What Does This Do
use okhttp library with branch 5.3 and instrument all methods from
package okhttp3/*
Motivation
Kotlin compiler does tricky thing when generating bytecode that
javacdoes notAllow to verify and ensure that log probe instrumentation works for kotlin most of the the time
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]