fix computeFrames call

[jpbempel]

What Does This Do

make sure it is called before any instrumentation. for CaptureContextInstrumenter, processInstructions is called after some instrumentation at the beginning of the method. so extract computeFrames outside of processInstructions and return directly the frames Map.

Motivation

Additional Notes

Contributor Checklist

• Format the title according to the contribution guidelines
• Assign the type: and (comp: or inst:) labels in addition to any other useful labels
• Avoid using close, fix, or any linking keywords when referencing an issue
  Use solves instead, and assign the PR milestone to the issue
• Update the CODEOWNERS file on source file addition, migration, or deletion
• Update public documentation with any new configuration flags or behaviors
• Once approved, use merge queue to merge the PR

Jira ticket: DEBUG-5816

[dd-octo-sts]

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

• Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

[datadog-prod-us1-6]

More details

Reviewed PR moving frame computation before instrumentation in debugger's bytecode processing. All call sites correctly updated across five instrumenter classes, signatures changed consistently, and no behavioral regressions identified. The fix addresses a real problem where analyzing instrumented bytecode could fail, by computing frames on the original bytecode first.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Datadog Autotest · Commit 6599436 · What is Autotest? · Any feedback? Reach out in #autotest}

[dd-octo-sts]

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	13.90 s	13.87 s	[-0.5%; +0.9%] (no difference)
startup:insecure-bank:tracing:Agent	12.91 s	12.95 s	[-1.1%; +0.6%] (no difference)
startup:petclinic:appsec:Agent	17.55 s	17.15 s	[+1.4%; +3.3%] (significantly worse)
startup:petclinic:iast:Agent	17.42 s	17.62 s	[-2.0%; -0.3%] (maybe better)
startup:petclinic:profiling:Agent	17.30 s	17.47 s	[-2.2%; +0.2%] (no difference)
startup:petclinic:sca:Agent	17.51 s	17.47 s	[-0.6%; +1.1%] (no difference)
startup:petclinic:tracing:Agent	16.50 s	16.24 s	[-2.7%; +5.9%] (no difference)

Commit: 65994362 · CI Pipeline · Benchmarking Platform UI

---

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

[Copilot]

Pull request overview

This PR adjusts debugger probe bytecode instrumentation to ensure ASM frame analysis (computeFrames) runs before any instruction list mutations, then passes the precomputed frames into processInstructions for return-rewrite/stack-cleanup logic.

Changes:

• Refactored Instrumenter.computeFrames to return the computed frame map, and updated processInstructions to accept it as an argument.
• Updated Span/Metric/Exception/CapturedContext instrumenters to compute frames up-front and pass them into processInstructions.
• Improved the AnalyzerException debug log to include the method descriptor.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/instrumentation/SpanInstrumenter.java	Precomputes frames before span instrumentation and passes them to processInstructions.
dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/instrumentation/MetricInstrumenter.java	Precomputes frames for EXIT instrumentation before rewriting returns.
dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/instrumentation/Instrumenter.java	Refactors frame computation API and updates instruction processing to take precomputed frames; enhances debug logging.
dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/instrumentation/ExceptionInstrumenter.java	Precomputes frames before processing instructions to set up return handling.
dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/instrumentation/CapturedContextInstrumenter.java	Computes frames before early method-entry instrumentation, then uses them for return processing.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[jpbempel]

not a problem.