-
Notifications
You must be signed in to change notification settings - Fork 340
feat(openfeature): emit server-side EVP flagevaluation #11639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leoromanovsky
wants to merge
27
commits into
master
Choose a base branch
from
leo.romanovsky/ffl-2446-evp-flagevaluation-java
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
95eb84b
test(02-05): add failing tests for FlagEvaluationWriterImpl two-tier …
leoromanovsky 724bd9f
feat(02-05): implement FlagEvaluationWriter interface + FlagEvaluatio…
leoromanovsky 304f8d5
test(02-05): add failing tests for FlagEvalEVPHook finallyAfter behavior
leoromanovsky abbec48
feat(02-05): add FlagEvalEVPHook + gateway wiring + killswitch
leoromanovsky fcc884e
style(02-05): apply google-java-format via spotlessApply
leoromanovsky 78bbaba
chore(openfeature): remove internal review annotations from EVP flage…
leoromanovsky be97d8d
feat(openfeature): add EVP flagevaluation error object, deterministic…
leoromanovsky c8c95a5
chore(openfeature): remove internal planning annotations
leoromanovsky c459981
fix(openfeature): suppress single-thread SpotBugs MT findings on flag…
leoromanovsky 8ef8ea4
fix(openfeature): align EVP flagevaluation aggregation with worker sc…
leoromanovsky 8823846
Merge remote-tracking branch 'origin/master' into workspace/flag-eval…
leoromanovsky 96a00db
Merge remote-tracking branch 'origin/master' into workspace/flag-eval…
leoromanovsky 8bd298b
Align flagevaluation EVP contract
leoromanovsky afe4d56
Fix flagevaluation writer test formatting
leoromanovsky 7f0cf1f
fix(openfeature): satisfy flagevaluation spotless
leoromanovsky cc3c75e
Remove flagevaluation schema validator fixture
leoromanovsky 9cc14b3
Share feature flag EVP publishing
leoromanovsky fd4dcf6
Merge remote-tracking branch 'origin/master' into workspace/flag-eval…
leoromanovsky 74f1407
Merge remote-tracking branch 'origin/master' into workspace/flag-eval…
leoromanovsky 3d4244f
fix(openfeature): align flagevaluation EVP transport
leoromanovsky 64ede83
fix(openfeature): bound flagevaluation evp payloads
leoromanovsky 033a471
fix(openfeature): emit flagevaluation telemetry counters
leoromanovsky c211de3
refactor(openfeature): share EVP limits and clarify hooks
leoromanovsky 64f5951
refactor(openfeature): clarify flag eval logging hook
leoromanovsky 6e699cf
style(feature-flagging): fix spotless formatting
leoromanovsky 15a04d7
style(openfeature): format flag eval logging test
leoromanovsky 4a93c61
test(evpproxy): use shared EVP header constant
leoromanovsky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
communication/src/main/java/datadog/communication/EvpProxy.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| package datadog.communication; | ||
|
|
||
| /** Shared EVP proxy constants. */ | ||
| public final class EvpProxy { | ||
|
|
||
| public static final String SUBDOMAIN_HEADER = "X-Datadog-EVP-Subdomain"; | ||
|
|
||
| /** EVP uncompressed request-body limit in bytes. */ | ||
| public static final int PAYLOAD_SIZE_LIMIT_BYTES = 5 * 1024 * 1024; | ||
|
|
||
| private EvpProxy() {} | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the flag-evaluation writer requests
V2_EVP_PROXY_ENDPOINT, Agents that advertise only/evp_proxy/v4/leaveevpProxyEndpointat the discovered v4 value because this condition simply skips the preference. The writer then posts to/evp_proxy/v4/api/v2/flagevaluation, despite this signal being documented in the new writer as using/evp_proxy/v2/api/v2/flagevaluation; those environments will send the new telemetry to the wrong Agent route instead of disabling it when v2 is unavailable.Useful? React with 👍 / 👎.