Add lazy-transformer to KeyClassifier for deferred header decoding#11466
Open
amarziali wants to merge 1 commit into
Open
Add lazy-transformer to KeyClassifier for deferred header decoding#11466amarziali wants to merge 1 commit into
amarziali wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do
Adds a default generic method to
AgentPropagation.KeyClassifier:The default applies the transformer eagerly and delegates to
accept(String, String), so existing classifiers need no changes.Motivation
Some carriers store header values in raw form (e.g.
byte[]) and have to convert them to strings before callingaccept. Right now that conversion happens for every header, including the ones the classifier immediately ignores.An example is kafka that's decoding into base64 all the headers without knowing if it's needed.
This overload lets callers pass the raw value and a conversion function. A classifier that rejects unknown keys early never pays for the conversion at all.
The concrete follow-up is the Kafka
TextMapExtractAdapter, where Base64-decoding all message headers is wasteful and currently throwsIllegalArgumentExceptionon non-Base64 input. That fix comes in a separate PR.Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-levelJira ticket: [PROJ-IDENT]