Conversation
drain metric collector singleton before each test
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 13 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~60c9cff55f, baseline=1.62.0-SNAPSHOT~4b85865643
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056447
Total [baseline] (11.061 s) : 0, 11061033
Agent [candidate] (1.053 s) : 0, 1052818
Total [candidate] (11.041 s) : 0, 11040705
section appsec
Agent [baseline] (1.258 s) : 0, 1257769
Total [baseline] (11.107 s) : 0, 11106759
Agent [candidate] (1.254 s) : 0, 1253749
Total [candidate] (11.2 s) : 0, 11199611
section iast
Agent [baseline] (1.228 s) : 0, 1227561
Total [baseline] (11.461 s) : 0, 11460596
Agent [candidate] (1.223 s) : 0, 1222544
Total [candidate] (11.238 s) : 0, 11238240
section profiling
Agent [baseline] (1.199 s) : 0, 1198837
Total [baseline] (11.216 s) : 0, 11215623
Agent [candidate] (1.184 s) : 0, 1183603
Total [candidate] (11.009 s) : 0, 11009293
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~60c9cff55f, baseline=1.62.0-SNAPSHOT~4b85865643
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.223 ms) : 0, 1223
crashtracking [candidate] (1.223 ms) : 0, 1223
BytebuddyAgent [baseline] (632.597 ms) : 0, 632597
BytebuddyAgent [candidate] (630.521 ms) : 0, 630521
AgentMeter [baseline] (29.624 ms) : 0, 29624
AgentMeter [candidate] (29.252 ms) : 0, 29252
GlobalTracer [baseline] (249.922 ms) : 0, 249922
GlobalTracer [candidate] (247.852 ms) : 0, 247852
AppSec [baseline] (32.155 ms) : 0, 32155
AppSec [candidate] (31.827 ms) : 0, 31827
Debugger [baseline] (60.154 ms) : 0, 60154
Debugger [candidate] (59.819 ms) : 0, 59819
Remote Config [baseline] (600.642 µs) : 0, 601
Remote Config [candidate] (588.412 µs) : 0, 588
Telemetry [baseline] (8.082 ms) : 0, 8082
Telemetry [candidate] (8.054 ms) : 0, 8054
Flare Poller [baseline] (5.947 ms) : 0, 5947
Flare Poller [candidate] (7.539 ms) : 0, 7539
section appsec
crashtracking [baseline] (1.238 ms) : 0, 1238
crashtracking [candidate] (1.227 ms) : 0, 1227
BytebuddyAgent [baseline] (666.97 ms) : 0, 666970
BytebuddyAgent [candidate] (665.354 ms) : 0, 665354
AgentMeter [baseline] (12.206 ms) : 0, 12206
AgentMeter [candidate] (12.159 ms) : 0, 12159
GlobalTracer [baseline] (251.108 ms) : 0, 251108
GlobalTracer [candidate] (250.532 ms) : 0, 250532
IAST [baseline] (24.868 ms) : 0, 24868
IAST [candidate] (24.688 ms) : 0, 24688
AppSec [baseline] (185.746 ms) : 0, 185746
AppSec [candidate] (184.698 ms) : 0, 184698
Debugger [baseline] (66.048 ms) : 0, 66048
Debugger [candidate] (65.838 ms) : 0, 65838
Remote Config [baseline] (610.53 µs) : 0, 611
Remote Config [candidate] (595.236 µs) : 0, 595
Telemetry [baseline] (8.713 ms) : 0, 8713
Telemetry [candidate] (8.587 ms) : 0, 8587
Flare Poller [baseline] (3.666 ms) : 0, 3666
Flare Poller [candidate] (3.554 ms) : 0, 3554
section iast
crashtracking [baseline] (1.226 ms) : 0, 1226
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (804.226 ms) : 0, 804226
BytebuddyAgent [candidate] (800.399 ms) : 0, 800399
AgentMeter [baseline] (11.488 ms) : 0, 11488
AgentMeter [candidate] (11.376 ms) : 0, 11376
GlobalTracer [baseline] (238.397 ms) : 0, 238397
GlobalTracer [candidate] (238.839 ms) : 0, 238839
IAST [baseline] (25.759 ms) : 0, 25759
IAST [candidate] (25.701 ms) : 0, 25701
AppSec [baseline] (30.157 ms) : 0, 30157
AppSec [candidate] (30.1 ms) : 0, 30100
Debugger [baseline] (61.69 ms) : 0, 61690
Debugger [candidate] (62.648 ms) : 0, 62648
Remote Config [baseline] (537.236 µs) : 0, 537
Remote Config [candidate] (523.954 µs) : 0, 524
Telemetry [baseline] (13.838 ms) : 0, 13838
Telemetry [candidate] (11.986 ms) : 0, 11986
Flare Poller [baseline] (3.547 ms) : 0, 3547
Flare Poller [candidate] (3.562 ms) : 0, 3562
section profiling
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (700.673 ms) : 0, 700673
BytebuddyAgent [candidate] (690.679 ms) : 0, 690679
AgentMeter [baseline] (9.202 ms) : 0, 9202
AgentMeter [candidate] (9.1 ms) : 0, 9100
GlobalTracer [baseline] (209.474 ms) : 0, 209474
GlobalTracer [candidate] (207.248 ms) : 0, 207248
AppSec [baseline] (33.033 ms) : 0, 33033
AppSec [candidate] (32.429 ms) : 0, 32429
Debugger [baseline] (66.574 ms) : 0, 66574
Debugger [candidate] (65.519 ms) : 0, 65519
Remote Config [baseline] (658.411 µs) : 0, 658
Remote Config [candidate] (586.598 µs) : 0, 587
Telemetry [baseline] (7.91 ms) : 0, 7910
Telemetry [candidate] (7.83 ms) : 0, 7830
Flare Poller [baseline] (3.589 ms) : 0, 3589
Flare Poller [candidate] (3.594 ms) : 0, 3594
ProfilingAgent [baseline] (94.332 ms) : 0, 94332
ProfilingAgent [candidate] (94.309 ms) : 0, 94309
Profiling [baseline] (94.914 ms) : 0, 94914
Profiling [candidate] (94.875 ms) : 0, 94875
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~60c9cff55f, baseline=1.62.0-SNAPSHOT~4b85865643
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1057593
Total [baseline] (8.883 s) : 0, 8882532
Agent [candidate] (1.061 s) : 0, 1060812
Total [candidate] (8.866 s) : 0, 8865650
section iast
Agent [baseline] (1.223 s) : 0, 1223350
Total [baseline] (9.55 s) : 0, 9550486
Agent [candidate] (1.226 s) : 0, 1226140
Total [candidate] (9.557 s) : 0, 9557245
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~60c9cff55f, baseline=1.62.0-SNAPSHOT~4b85865643
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.24 ms) : 0, 1240
crashtracking [candidate] (1.245 ms) : 0, 1245
BytebuddyAgent [baseline] (632.892 ms) : 0, 632892
BytebuddyAgent [candidate] (635.729 ms) : 0, 635729
AgentMeter [baseline] (29.409 ms) : 0, 29409
AgentMeter [candidate] (29.644 ms) : 0, 29644
GlobalTracer [baseline] (248.57 ms) : 0, 248570
GlobalTracer [candidate] (249.82 ms) : 0, 249820
AppSec [baseline] (32.058 ms) : 0, 32058
AppSec [candidate] (32.342 ms) : 0, 32342
Debugger [baseline] (59.502 ms) : 0, 59502
Debugger [candidate] (59.633 ms) : 0, 59633
Remote Config [baseline] (608.397 µs) : 0, 608
Remote Config [candidate] (596.786 µs) : 0, 597
Telemetry [baseline] (8.105 ms) : 0, 8105
Telemetry [candidate] (8.176 ms) : 0, 8176
Flare Poller [baseline] (9.022 ms) : 0, 9022
Flare Poller [candidate] (7.404 ms) : 0, 7404
section iast
crashtracking [baseline] (1.239 ms) : 0, 1239
crashtracking [candidate] (1.218 ms) : 0, 1218
BytebuddyAgent [baseline] (801.249 ms) : 0, 801249
BytebuddyAgent [candidate] (802.225 ms) : 0, 802225
AgentMeter [baseline] (11.382 ms) : 0, 11382
AgentMeter [candidate] (11.455 ms) : 0, 11455
GlobalTracer [baseline] (238.947 ms) : 0, 238947
GlobalTracer [candidate] (240.244 ms) : 0, 240244
IAST [baseline] (26.675 ms) : 0, 26675
IAST [candidate] (25.92 ms) : 0, 25920
AppSec [baseline] (30.916 ms) : 0, 30916
AppSec [candidate] (30.396 ms) : 0, 30396
Debugger [baseline] (59.696 ms) : 0, 59696
Debugger [candidate] (62.318 ms) : 0, 62318
Remote Config [baseline] (1.165 ms) : 0, 1165
Remote Config [candidate] (1.138 ms) : 0, 1138
Telemetry [baseline] (12.264 ms) : 0, 12264
Telemetry [candidate] (11.242 ms) : 0, 11242
Flare Poller [baseline] (3.447 ms) : 0, 3447
Flare Poller [candidate] (3.453 ms) : 0, 3453
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~60c9cff55f, baseline=1.62.0-SNAPSHOT~4b85865643
dateFormat X
axisFormat %s
section baseline
no_agent (1.248 ms) : 1236, 1259
. : milestone, 1248,
iast (3.315 ms) : 3270, 3361
. : milestone, 3315,
iast_FULL (5.913 ms) : 5853, 5974
. : milestone, 5913,
iast_GLOBAL (3.656 ms) : 3591, 3722
. : milestone, 3656,
profiling (2.177 ms) : 2156, 2199
. : milestone, 2177,
tracing (1.896 ms) : 1880, 1912
. : milestone, 1896,
section candidate
no_agent (1.268 ms) : 1256, 1281
. : milestone, 1268,
iast (3.341 ms) : 3293, 3388
. : milestone, 3341,
iast_FULL (6.014 ms) : 5952, 6075
. : milestone, 6014,
iast_GLOBAL (3.723 ms) : 3660, 3785
. : milestone, 3723,
profiling (2.22 ms) : 2199, 2241
. : milestone, 2220,
tracing (1.907 ms) : 1890, 1924
. : milestone, 1907,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~60c9cff55f, baseline=1.62.0-SNAPSHOT~4b85865643
dateFormat X
axisFormat %s
section baseline
no_agent (19.271 ms) : 19069, 19472
. : milestone, 19271,
appsec (18.407 ms) : 18218, 18595
. : milestone, 18407,
code_origins (18.707 ms) : 18518, 18897
. : milestone, 18707,
iast (17.906 ms) : 17734, 18079
. : milestone, 17906,
profiling (20.123 ms) : 19927, 20320
. : milestone, 20123,
tracing (18.2 ms) : 18022, 18379
. : milestone, 18200,
section candidate
no_agent (17.949 ms) : 17766, 18132
. : milestone, 17949,
appsec (18.707 ms) : 18519, 18896
. : milestone, 18707,
code_origins (17.793 ms) : 17619, 17966
. : milestone, 17793,
iast (17.967 ms) : 17789, 18145
. : milestone, 17967,
profiling (19.38 ms) : 19185, 19576
. : milestone, 19380,
tracing (17.656 ms) : 17482, 17830
. : milestone, 17656,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~60c9cff55f, baseline=1.62.0-SNAPSHOT~4b85865643
dateFormat X
axisFormat %s
section baseline
no_agent (1.489 ms) : 1477, 1500
. : milestone, 1489,
appsec (3.85 ms) : 3627, 4073
. : milestone, 3850,
iast (2.277 ms) : 2207, 2346
. : milestone, 2277,
iast_GLOBAL (2.317 ms) : 2248, 2386
. : milestone, 2317,
profiling (2.104 ms) : 2049, 2159
. : milestone, 2104,
tracing (2.096 ms) : 2042, 2150
. : milestone, 2096,
section candidate
no_agent (1.495 ms) : 1483, 1507
. : milestone, 1495,
appsec (2.553 ms) : 2498, 2607
. : milestone, 2553,
iast (2.275 ms) : 2206, 2344
. : milestone, 2275,
iast_GLOBAL (2.322 ms) : 2253, 2392
. : milestone, 2322,
profiling (2.098 ms) : 2044, 2153
. : milestone, 2098,
tracing (2.084 ms) : 2030, 2138
. : milestone, 2084,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~60c9cff55f, baseline=1.62.0-SNAPSHOT~4b85865643
dateFormat X
axisFormat %s
section baseline
no_agent (15.672 s) : 15672000, 15672000
. : milestone, 15672000,
appsec (14.743 s) : 14743000, 14743000
. : milestone, 14743000,
iast (18.306 s) : 18306000, 18306000
. : milestone, 18306000,
iast_GLOBAL (18.011 s) : 18011000, 18011000
. : milestone, 18011000,
profiling (14.787 s) : 14787000, 14787000
. : milestone, 14787000,
tracing (14.923 s) : 14923000, 14923000
. : milestone, 14923000,
section candidate
no_agent (15.439 s) : 15439000, 15439000
. : milestone, 15439000,
appsec (15.033 s) : 15033000, 15033000
. : milestone, 15033000,
iast (18.594 s) : 18594000, 18594000
. : milestone, 18594000,
iast_GLOBAL (18.154 s) : 18154000, 18154000
. : milestone, 18154000,
profiling (15.053 s) : 15053000, 15053000
. : milestone, 15053000,
tracing (14.959 s) : 14959000, 14959000
. : milestone, 14959000,
|
PerfectSlayer
left a comment
There was a problem hiding this comment.
Thanks for the fix
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 107586200 took longer than expected. The current limit for the base branch 'master' is 120 minutes. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 107657126 took longer than expected. The current limit for the base branch 'master' is 120 minutes. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 107696782 took longer than expected. The current limit for the base branch 'master' is 120 minutes. |
What Does This Do
drain metric collector singleton before each test
Motivation
Additional Notes
related to #11092
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.