You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When reading the DD_TRACE_AGENT_URL, DD_AGENT_HOST and DD_TRACE_AGENT_PORT environment variables for the configuration of the agent, consider empty values as unset.
performance/ignore-performance-regression: We get very often high values for BM_TraceID_ParseHex whereas the relative code has not been touched:
[STDERR] Fail on regression | FAIL! Metric MetricName.EXECUTION_TIME in scenario:BM_TraceID_ParseHex/64bit has regression +32.48%, larger than threshold 5.00%.
[STDERR] Fail on regression | FAIL! Metric MetricName.EXECUTION_TIME in scenario:BM_TraceID_ParseHex/128bit has regression +40.50%, larger than threshold 5.00%.
xlamorlette-datadog
changed the title
For agent URL configuration, consider empty environment variables as …
For agent URL configuration, consider empty environment variables as unset
Aug 12, 2026
Comparing candidate commit af3dcdb in PR branch xlamorlette/fix-empty-agent-env-variables with baseline commit 2e86335 in branch main.
Found 0 performance improvements and 2 performance regressions! Performance is the same for 6 metrics, 0 unstable metrics.
Explanation
This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:
🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline
We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.
If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.
Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.
More details about the CI and significant changes
You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.
CIs of the difference of means are often centered around 0%, because often changes are not that big:
---------------------------------(------|---^--------)-------------------------------->
-0.6% 0% 0.3% +1.2%
| | |
lower bound of the CI --' | |
sample mean (center of the CI) -------------' |
upper bound of the CI ----------------------'
As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).
For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:
----------------------------------------|---------|---(---------^---------)---------->
0% 1% 1.3% 2.2% 3.1%
| | | |
significant impact threshold --------------' | | |
lower bound of CI --------------' | |
sample mean (center of the CI) --------------------------' |
upper bound of CI ----------------------------------'
scenario:BM_TraceID_ParseHex/128bit
🟥 execution_time [+49.771ns; +49.956ns] or [+40.504%; +40.656%]
scenario:BM_TraceID_ParseHex/64bit
🟥 execution_time [+22.502ns; +22.517ns] or [+32.484%; +32.505%]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When reading the
DD_TRACE_AGENT_URL,DD_AGENT_HOSTandDD_TRACE_AGENT_PORTenvironment variables for the configuration of the agent, consider empty values as unset.Motivation
This was discovered when activating the handling of IPv6 agent host addresses in System Tests. See the error:
Actually, this does not come from the newly implemented handling of IPv6 agent host addresses, this was a bug already present before.
Additional Notes
Jira ticket: IDMPL-760 [C++ Tracer] Bug: empty environment variables for agent configuration not handled correctly
performance/ignore-performance-regression: We get very often high values forBM_TraceID_ParseHexwhereas the relative code has not been touched: