Skip to content

Add support for IPv6 addresses for the agent in the tracer configuration - #350

Merged
xlamorlette-datadog merged 14 commits into
mainfrom
xlamorlette/agent-host-ipv6
Aug 12, 2026
Merged

Add support for IPv6 addresses for the agent in the tracer configuration#350
xlamorlette-datadog merged 14 commits into
mainfrom
xlamorlette/agent-host-ipv6

Conversation

@xlamorlette-datadog

@xlamorlette-datadog xlamorlette-datadog commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Description

Add support for IPv6 addresses for the agent in the tracer configuration.

The only change is surrounding IPv6 addresses with brackets when building the agent URL.

Additional Notes

In src/datadog/datadog_agent_config.cpp, the main part of build_agent_url_from_environment_variables() is an extraction and a cleaning of what was in load_datadog_agent_env_config().

Jira ticket: IMPL-185 C++ Tracer support IPv6

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Aug 10, 2026

Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 84.47% (+0.03%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6a8a1fe | Docs | Datadog PR Page | Give us feedback!

@pr-commenter

pr-commenter Bot commented Aug 10, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-08-11 16:29:58

Comparing candidate commit 6a8a1fe in PR branch xlamorlette/agent-host-ipv6 with baseline commit 6f1d9e4 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@xlamorlette-datadog xlamorlette-datadog changed the title For system tests, get the agent URL from the tracer configuration instead of simply checking the environment variable Add support of IPv6 addresses for the agent in the tracer configuration Aug 11, 2026
@xlamorlette-datadog xlamorlette-datadog changed the title Add support of IPv6 addresses for the agent in the tracer configuration Add support for IPv6 addresses for the agent in the tracer configuration Aug 11, 2026
@xlamorlette-datadog
xlamorlette-datadog marked this pull request as ready for review August 11, 2026 16:27
@xlamorlette-datadog
xlamorlette-datadog requested review from a team as code owners August 11, 2026 16:27
@xlamorlette-datadog
xlamorlette-datadog requested review from dubloom and removed request for a team August 11, 2026 16:27
@xlamorlette-datadog
xlamorlette-datadog merged commit f62ba8d into main Aug 12, 2026
38 checks passed
@xlamorlette-datadog
xlamorlette-datadog deleted the xlamorlette/agent-host-ipv6 branch August 12, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants