feat(flags): add rules engine boundary (FFL-2837 PR1) - #1346
Draft
btthomas wants to merge 17 commits into
Draft
Conversation
This was referenced Jul 24, 2026
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR1
branch
from
July 27, 2026 19:53
bb7ad12 to
d8dd76f
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837
branch
from
July 28, 2026 16:51
4878144 to
7b00adc
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR1
branch
4 times, most recently
from
July 31, 2026 13:58
f614832 to
78d60c2
Compare
|
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR1
branch
from
August 3, 2026 15:45
78d60c2 to
4902bc1
Compare
This was referenced Aug 5, 2026
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR1
branch
from
August 7, 2026 12:23
59cbac3 to
8dc8c27
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR1
branch
from
August 10, 2026 18:54
8dc8c27 to
dcd5e65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request stack
This description uses Simplified Technical English. Technical names and API names do not change.
Summary
This PR adds the internal boundary for dynamic offline rule evaluation. It also makes precomputed context handling explicit.
{}) as a real context.getPrecomputedContext(configuration)as a public temporary helper.getPrecomputedContext.FlagsClient. PR2 adds that behavior.Reason
The React Native SDK must not implement a second production rules engine. The adapter keeps flagging-core details out of the SDK state machine. Tests can replace the adapter with a deterministic fake.
OpenFeature supplies
{}for an unset or cleared global context. The provider cannot distinguish that state from an explicit{}. Therefore, the provider must treat{}literally. A context-specific precomputed customer must explicitly set the matching context.Upstream contract
Published flagging-core version 2.0.2 does not contain the protobuf rules wire from openfeature-js-client#344. PR #344 is currently at
939da97.The two latest PR #344 commits only refresh generated Node-server declarations and isolate browser tests. They do not change this React Native contract.
openfeature-js-client#353 adds the shared
getPrecomputedContexthelper. After publication, this PR must re-export the upstream helper and delete the local clone implementation.After PR #344 is published, this PR must use the upstream parser and evaluator directly. It must not keep a local protobuf decoder or a second structural validator.
Temporary code
This PR contains 15
TODO(FFL-2837)markers:getPrecomputedContexthelper.Keep the reserved-name and provider-bootstrap tests after the upstream migration. The fake rules engine is a permanent unit-test boundary.
User impact
This PR does not expose dynamic rules evaluation. It changes precomputed context behavior.
{}no longer restores the context that is stored in a precomputed configuration.OpenFeature.clearContext()does not restore the stored configuration context.getPrecomputedContext(configuration)returns a supported detached copy.Checks