[RUM-7591] Update React Native Hybrid App to RN 0.79 and latest SDK#38
Open
marco-saia-datadog wants to merge 2 commits intomainfrom
Open
[RUM-7591] Update React Native Hybrid App to RN 0.79 and latest SDK#38marco-saia-datadog wants to merge 2 commits intomainfrom
marco-saia-datadog wants to merge 2 commits intomainfrom
Conversation
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
Comment on lines
+19
to
+24
| override fun getPackages(): List<ReactPackage> = | ||
| PackageList(this).packages.apply { | ||
| // Packages that cannot be autolinked yet can be added manually here, for example: | ||
| // add(MyReactNativePackage()) | ||
| add(MyAppPackage()) | ||
| } |
There was a problem hiding this comment.
⚪ Code Quality Violation
Function return type should be preceded by a single space. (...read more)
Kotlin enforces consistent spacing around the function return type: one space before the return type.
Comment on lines
+22
to
+23
| override fun createReactActivityDelegate(): ReactActivityDelegate = | ||
| DefaultReactActivityDelegate(this, mainComponentName, fabricEnabled) |
There was a problem hiding this comment.
⚪ Code Quality Violation
Function return type should be preceded by a single space. (...read more)
Kotlin enforces consistent spacing around the function return type: one space before the return type.
| override fun getJSMainModuleName(): String { | ||
| return "index" | ||
| } | ||
| override fun getJSMainModuleName(): String = "index" |
There was a problem hiding this comment.
⚪ Code Quality Violation
Suggested change
| override fun getJSMainModuleName(): String = "index" | |
| override fun getJSMainModuleName(): String = "index" |
Function return type should be preceded by a single space. (...read more)
Kotlin enforces consistent spacing around the function return type: one space before the return type.
| override val isHermesEnabled: Boolean | ||
| protected get() = BuildConfig.IS_HERMES_ENABLED | ||
| } | ||
| override fun getUseDeveloperSupport(): Boolean = BuildConfig.DEBUG |
There was a problem hiding this comment.
⚪ Code Quality Violation
Suggested change
| override fun getUseDeveloperSupport(): Boolean = BuildConfig.DEBUG | |
| override fun getUseDeveloperSupport(): Boolean = BuildConfig.DEBUG |
Function return type should be preceded by a single space. (...read more)
Kotlin enforces consistent spacing around the function return type: one space before the return type.
|
|
||
| # Exclude problematic versions of cocoapods and activesupport that causes build failures. | ||
| gem 'cocoapods', '>= 1.13', '!= 1.15.0', '!= 1.15.1' | ||
| gem 'activesupport', '>= 6.1.7.5', '!= 7.1.0' |
There was a problem hiding this comment.
🟠 Library Vulnerability
activesupport → 6.1.7.2
View all suggested fixes
Suggested change
| gem 'activesupport', '>= 6.1.7.5', '!= 7.1.0' | |
| gem 'activesupport', 7.1.0 '!= 7.1.0' |
Suggested change
| gem 'activesupport', '>= 6.1.7.5', '!= 7.1.0' | |
| gem 'activesupport', 6.1.7.5 '!= 7.1.0' |
Active Support Possibly Discloses Locally Encrypted Files (...read more)
sbarrio
reviewed
Jul 28, 2025
| "dependencies": { | ||
| "@datadog/mobile-react-native": "^2.4.4", | ||
| "@datadog/mobile-react-navigation": "^2.4.4", | ||
| "@datadog/mobile-react-native": "2.7.0", |
Contributor
There was a problem hiding this comment.
Should we bump it directly to the latest 2.10.1?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the React Native hybrid app example to the latest version of React Native (0.79), and of our React Native SDK (2.7.0).
In addition, Session Replay has been introduced in the example project.
Review checklist (to be filled by reviewers)