Repository navigation
Cover object-store contention and computation failures - #146
Merged
Merged
Conversation
mcculls
force-pushed
the
mcculls/object-store-edge-case-tests
branch
from
October 18, 2026 18:36
41f600c to
246e691
Compare
AlexeyKuznetsov-DD
approved these changes
Oct 20, 2026
AlexeyKuznetsov-DD
left a comment
AlexeyKuznetsov-DD
left a comment
There was a problem hiding this comment.
LGTM. left couple of minor notes.
Would be nice to have a note in PR description why 2 *.git files were deleted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds object-store tests for same-key contention, null values, and failed computations followed by successful retries. Generated dispatch tests verify that exceptions from compute functions and accessors release the monitor so another thread can retry.
Motivation
Existing tests exercise successful dispatch and global-store operations, but leave exception cleanup, null-result retries, and concurrent computation insufficiently covered. The dispatch contention test now forces every contender through its initial miss and checks that only one value is computed and stored.
Additional Notes
Validation:
./gradlew :field-inject:check --offline --no-configuration-cachepasses, including 59 tests on each of Java 8, 11, 17, 21, and 25, Spotless, SpotBugs, and coverage generation.Also removes two stale doc images relating to ObjectStore that are no longer required.