Open
Conversation
1b31a06 to
ef7d3a3
Compare
c2fd653 to
e3bcd2f
Compare
pducolin
reviewed
Nov 29, 2024
.gitlab-ci.yml
Outdated
| # Retrieve common go deps | ||
| - mkdir -p $GOPATH/pkg/mod && tar xJf modcache_e2e.tar.xz -C $GOPATH/pkg/mod && rm -f modcache_e2e.tar.xz | ||
| # Install orchestrion | ||
| - go install github.com/DataDog/orchestrion@v0.9.4 |
Contributor
There was a problem hiding this comment.
💭 thought
We could install orchestrion in our e2e runner image, defined in `test-infra-definitions. Can be a follow up and we can handle it
Member
Author
There was a problem hiding this comment.
yes we can do that, just keep in mind that v0.9.4 is an non GA version. Currently the stable version requires a recent Go version (>= 1.22.9) so it must be in sync with the Go version you are using.
pducolin
reviewed
Nov 29, 2024
pducolin
approved these changes
Nov 29, 2024
Co-authored-by: pducolin <45568537+pducolin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the usage of the junitxml files with the Go native instrumentation using orchestrion for the Test Optimization product
Results: https://app.datadoghq.com/ci/test-branch/gitlab.ddbuild.io%2FDataDog%2Fagent-linux-install-script/agent-linux-install-script/tony%2Ftest-visibility?query=test_level%3Atest%20env%3Aci%20%40git.repository.id%3Agitlab.ddbuild.io%2FDataDog%2Fagent-linux-install-script%20%40test.service%3Aagent-linux-install-script%20%40git.branch%3Atony%2Ftest-visibility&env=ci&fromUser=false&index=citest&start=1730295156612&end=1732887156612&paused=false