fix: ensure WASM sha in docs matches released binary - #432
Merged
Conversation
Upload the WASM as a versioned artifact in gen-release-pr.yml, then download that same artifact in release.yml instead of fetching a fresh build. This guarantees the SHA embedded in the docs during the release-prep PR matches the SHA of the published WASM.
This was referenced Jul 25, 2026
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a release-prep PR merges,
release.ymldownloads a fresh WASM artifact from the Build workflow (triggered by the merge commit). The SHA of that fresh binary rarely matches the SHA computed duringgen-release-pr.yml, so the docs end up with a stale/incorrect SHA.Solution
Two changes:
gen-release-pr.ymlAfter computing the SHA and regenerating docs, upload the WASM as a versioned artifact (
wasm-vX.Y.Z).release.ymlgen-release-pr.ymlinstead of the latestbuild.ymlrunThis guarantees the exact same
plugin.wasmbinary is used for both doc SHA computation and release upload.Flow
wasm-filegen-release-pr.ymltriggers → downloads it, computes SHA, regenerates docs, uploadswasm-vX.Y.Z, creates release-prep PRrelease.ymltriggers → extracts version from commit message → downloadswasm-vX.Y.Zfrom step 2 → creates release with the same binary → SHA matches the docs