Skip to content

New regression test to verify that we don't get duplicate TriggerActivities#435

Open
bieryAtFnal wants to merge 6 commits into
developfrom
kbiery/no_duplicate_ta_test
Open

New regression test to verify that we don't get duplicate TriggerActivities#435
bieryAtFnal wants to merge 6 commits into
developfrom
kbiery/no_duplicate_ta_test

Conversation

@bieryAtFnal

Copy link
Copy Markdown
Contributor

Description

For some time, we have noticed that duplicate TriggerActivity objects are occasionally observed in our regression tests. We believe that the underlying problem was the creation of duplicate TriggerPrimitive objects by the data-handling code in emulated-data running and that this problem has been fixed in DUNE-DAQ/datahandlinglibs#106.

This new regression test uses DUNE-DAQ configuration parameters that highlight the presence of duplicate TAs. We would like to add this regression test to our test suite so that we can be confident that this problem doesn't resurface.

Here are instructions for running the new test:

DATE_PREFIX=`date '+%d%b'`
TIME_SUFFIX=`date '+%H%M'`

source /cvmfs/dunedaq.opensciencegrid.org/setup_dunedaq.sh
setup_dbt latest
dbt-create -n NFD_DEV_260707_A9 ${DATE_PREFIX}FDDevTest_${TIME_SUFFIX}
cd ${DATE_PREFIX}FDDevTest_${TIME_SUFFIX}/sourcecode

git clone https://github.com/DUNE-DAQ/daqsystemtest.git -b develop
git clone https://github.com/DUNE-DAQ/trigger.git -b kbiery/no_duplicate_ta_test
cd ..

. ./env.sh
dbt-build -j 12
dbt-workarea-env

dunedaq_integtest_bundle.sh -r trigger -k duplicate

echo ""
echo -e "\U1F535 \U2705 Note that the integtest reported no problems with duplicate TAs. \U2705 \U1F535"
echo ""
echo ""

Type of change

  • Optimization (non-breaking change that improves code/performance)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas

@bieryAtFnal bieryAtFnal requested a review from denizergonul July 7, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants