Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
No parent issue linked yet.
This PR exposes DAPHNE Ethernet peak descriptor arrays through the
rawdatautilsDAPHNE Ethernet unpacker bindings for the FDDAQv5.5.0targetenvironment.
The branch is based directly on the package
fddaq-v5.5.0tag and intentionallyavoids unrelated later
develophistory. In particular, it avoids carrying thenewer
FragmentHeader.status_bitsAPI into this FDDAQv5.5.0branch, wherethe matching fragment header field is still
error_bits.Target environment:
fddaq-v5.5.0-a9-1fddaq-v5.5.0/v2.6.0np04-srv-017Dependencies:
fddetdataformatsbranchmarroyav/daphneeth-fddaq-v5_5_0, which adds the DAPHNE Ethernet peakdescriptor API used by this unpacker.
Reviewer test instructions:
Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Testing performed on
np04-srv-017:dbt-build -c -j4passed.dbt-build --unittest rawdatautilspassed.43950,VD_CathodePDS,record
(1, 0):800:1407DAPHNEEthframes801:1395DAPHNEEthframes--adc-statscompleted successfully and printedper-channel
DAPHNEAnalysisDatasummaries.Minimal system quicktest, full integration tests, separate Python pytest, and
pre-commit were not run.
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))
dbt-build --lintwas not run. No new rawdatautils unit test was added; thechange is covered by the build, existing package unit test, and the real-data
DAPHNE Ethernet decode smoke test listed above.