fix #5494: enable rotate to show surrounding pages on navigation#5505
Open
guillermo-escire wants to merge 5 commits intoDSpace:mainfrom
Open
fix #5494: enable rotate to show surrounding pages on navigation#5505guillermo-escire wants to merge 5 commits intoDSpace:mainfrom
guillermo-escire wants to merge 5 commits intoDSpace:mainfrom
Conversation
dff490b to
090d71a
Compare
Contributor
Author
|
Hi @lgeggleston , Frontend tests pass successfully (5821/5821). CI is failing when starting the DSpace REST backend via Docker: "no matching manifest for linux/amd64" (dspacesolr image) This appears to be unrelated to this PR and likely an upstream CI/Docker issue. |
|
@guillermo-escire thanks! Yes, looks like there was just an unrelated failure on the last backend Docker image build, so I'll re-run the tests when that's fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Fixes #5494
Description
Pagination control was not showing surrounding page numbers when navigating to later pages. Fixed by enabling rotate on the ngb-pagination component so it centers the active page within the visible range.
Instructions for Reviewers
List of changes in this PR:
How to test:
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.