Skip to content

DS-4766 replacement: updates ORCID icon and link displays according to their guidelines#5489

Merged
tdonohue merged 4 commits intoDSpace:mainfrom
TexasDigitalLibrary:DS-4766-replacement
Apr 17, 2026
Merged

DS-4766 replacement: updates ORCID icon and link displays according to their guidelines#5489
tdonohue merged 4 commits intoDSpace:mainfrom
TexasDigitalLibrary:DS-4766-replacement

Conversation

@nwoodward
Copy link
Copy Markdown
Contributor

References

Description

This is a replacement for @Sondissimo's excellent PR: #4766. All credit goes to them. This PR is essentially the same as theirs but includes some minor HTML and CSS changes to make the custom field appear more like generic item fields. It also incorporates the new change in the icon for unauthenticated ORCID ID's mentioned in #4656 (comment).

Instructions for Reviewers

For a list of instructions to review and test see the original PR: #4766.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@lgeggleston lgeggleston added bug integration: ORCID Related to integration with ORCID identifier system port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Apr 16, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Apr 16, 2026
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @nwoodward and @Sondissimo ! This is working for me. I've verified that it addresses the display guidelines laid out in #4656.

Will attempt to auto-backport this, but it's possible this will require manual backports

@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 10.0 Release Apr 17, 2026
@tdonohue tdonohue added this to the 10.0 milestone Apr 17, 2026
@tdonohue tdonohue merged commit 87bc813 into DSpace:main Apr 17, 2026
16 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Apr 17, 2026
@dspace-bot
Copy link
Copy Markdown
Contributor

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-5489-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-5489-to-dspace-7_x
git switch --create backport-5489-to-dspace-7_x
git cherry-pick -x 5e7a0d6d01707a2ad102b8a823e7fa6c8114f2be 19fd9153f28b217c778048e4090bf64aee23a658 33bf3e4cb0d46beed1b3f397ce1b4e6bb269a8c0 8dcf4e17c9343eefc7fefc8b8bf43652ae027909

@dspace-bot
Copy link
Copy Markdown
Contributor

Backport failed for dspace-8_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-8_x
git worktree add -d .worktree/backport-5489-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-5489-to-dspace-8_x
git switch --create backport-5489-to-dspace-8_x
git cherry-pick -x 5e7a0d6d01707a2ad102b8a823e7fa6c8114f2be 19fd9153f28b217c778048e4090bf64aee23a658 33bf3e4cb0d46beed1b3f397ce1b4e6bb269a8c0 8dcf4e17c9343eefc7fefc8b8bf43652ae027909

@dspace-bot
Copy link
Copy Markdown
Contributor

Backport failed for dspace-9_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-9_x
git worktree add -d .worktree/backport-5489-to-dspace-9_x origin/dspace-9_x
cd .worktree/backport-5489-to-dspace-9_x
git switch --create backport-5489-to-dspace-9_x
git cherry-pick -x 5e7a0d6d01707a2ad102b8a823e7fa6c8114f2be 19fd9153f28b217c778048e4090bf64aee23a658 33bf3e4cb0d46beed1b3f397ce1b4e6bb269a8c0 8dcf4e17c9343eefc7fefc8b8bf43652ae027909

@tdonohue
Copy link
Copy Markdown
Member

@nwoodward : As suspected, this unfortunately couldn't be auto-backported. If you can find time to backport this to at least 9.x, you can assign me as a reviewer & I'll get it merged quickly. (We could also backport to 8.x and 7.x, but we only guarantee bug fixes to 9.x currently)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug integration: ORCID Related to integration with ORCID identifier system port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

ORCID iDs should be displayed according to ORCID's Display Guidelines

4 participants