DS-4766 replacement: updates ORCID icon and link displays according to their guidelines#5489
Conversation
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @nwoodward and @Sondissimo ! This is working for me. I've verified that it addresses the display guidelines laid out in #4656.
Will attempt to auto-backport this, but it's possible this will require manual backports
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-7_x
git worktree add -d .worktree/backport-5489-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-5489-to-dspace-7_x
git switch --create backport-5489-to-dspace-7_x
git cherry-pick -x 5e7a0d6d01707a2ad102b8a823e7fa6c8114f2be 19fd9153f28b217c778048e4090bf64aee23a658 33bf3e4cb0d46beed1b3f397ce1b4e6bb269a8c0 8dcf4e17c9343eefc7fefc8b8bf43652ae027909 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-8_x
git worktree add -d .worktree/backport-5489-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-5489-to-dspace-8_x
git switch --create backport-5489-to-dspace-8_x
git cherry-pick -x 5e7a0d6d01707a2ad102b8a823e7fa6c8114f2be 19fd9153f28b217c778048e4090bf64aee23a658 33bf3e4cb0d46beed1b3f397ce1b4e6bb269a8c0 8dcf4e17c9343eefc7fefc8b8bf43652ae027909 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-9_x
git worktree add -d .worktree/backport-5489-to-dspace-9_x origin/dspace-9_x
cd .worktree/backport-5489-to-dspace-9_x
git switch --create backport-5489-to-dspace-9_x
git cherry-pick -x 5e7a0d6d01707a2ad102b8a823e7fa6c8114f2be 19fd9153f28b217c778048e4090bf64aee23a658 33bf3e4cb0d46beed1b3f397ce1b4e6bb269a8c0 8dcf4e17c9343eefc7fefc8b8bf43652ae027909 |
|
@nwoodward : As suspected, this unfortunately couldn't be auto-backported. If you can find time to backport this to at least 9.x, you can assign me as a reviewer & I'll get it merged quickly. (We could also backport to 8.x and 7.x, but we only guarantee bug fixes to 9.x currently) |
References
Description
This is a replacement for @Sondissimo's excellent PR: #4766. All credit goes to them. This PR is essentially the same as theirs but includes some minor HTML and CSS changes to make the custom field appear more like generic item fields. It also incorporates the new change in the icon for unauthenticated ORCID ID's mentioned in #4656 (comment).
Instructions for Reviewers
For a list of instructions to review and test see the original PR: #4766.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.