Skip to content

Fix #5410: fix issue with missing update on CMS metadata and end user agreement#5467

Open
FrancescoMolinaro wants to merge 1 commit intoDSpace:mainfrom
4Science:task/main/DURACOM-469
Open

Fix #5410: fix issue with missing update on CMS metadata and end user agreement#5467
FrancescoMolinaro wants to merge 1 commit intoDSpace:mainfrom
4Science:task/main/DURACOM-469

Conversation

@FrancescoMolinaro
Copy link
Copy Markdown
Contributor

References

Fixes: #5410

Description

Adapted find method of site data service to use projections and so include all languages.

Instructions for Reviewers

Improved method in data service, improved tests.

Steps to reproduce the behavior:

Go to Edit user agreement.
Add a user agreement in any language. Example: Italian.
Create a new account.
Click the activation link from the email inbox.
Change the language.
Observe that the copy does change.

image image

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@lgeggleston lgeggleston added bug component: administrative tools Related to the admin menu or tools 1 APPROVAL pull request only requires a single approval to merge testathon Reported by a tester during Community Testathon DSpace-CRIS merger This ticket/PR relates to the merger of DSpace-CRIS into DSpace. labels Apr 10, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug component: administrative tools Related to the admin menu or tools DSpace-CRIS merger This ticket/PR relates to the merger of DSpace-CRIS into DSpace. testathon Reported by a tester during Community Testathon

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

User agreement copy does not update after changing language during account activation

2 participants