Skip to content

Missing czech i18n translations#5409

Open
Kasinhou wants to merge 4 commits intoDSpace:mainfrom
dataquest-dev:czech-translation-dspace10
Open

Missing czech i18n translations#5409
Kasinhou wants to merge 4 commits intoDSpace:mainfrom
dataquest-dev:czech-translation-dspace10

Conversation

@Kasinhou
Copy link
Copy Markdown
Contributor

@Kasinhou Kasinhou commented Apr 7, 2026

Description

Translated missing czech messages.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added 1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs labels Apr 7, 2026
@tdonohue tdonohue added this to the 10.0 milestone Apr 7, 2026
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @Kasinhou for the updated translations. These all look good to me

@github-project-automation github-project-automation bot moved this to 👍 Reviewer Approved in DSpace 10.0 Release Apr 7, 2026
@tdonohue tdonohue changed the base branch from dspace-10.0-testathon to main April 7, 2026 15:54
@tdonohue
Copy link
Copy Markdown
Member

tdonohue commented Apr 7, 2026

@Kasinhou : One note however. I Just realized this PR is built against the dspace-10.0-testathon branch. We need all PRs to be against main (and we'll copy them over to the testathon branch as needed).

I just switched this PR to be against the main branch, but now it has code conflicts. Could you resolve those conflicts or resubmit the PR against the main branch?

@Kasinhou
Copy link
Copy Markdown
Contributor Author

Kasinhou commented Apr 8, 2026

@Kasinhou : One note however. I Just realized this PR is built against the dspace-10.0-testathon branch. We need all PRs to be against main (and we'll copy them over to the testathon branch as needed).

I just switched this PR to be against the main branch, but now it has code conflicts. Could you resolve those conflicts or resubmit the PR against the main branch?

@tdonohue thank you for the clarification. I have resolved the conflicts and also translated additional i18n keys in this update.
Please hold off on merging this PR for now - I would like our Czech community to review those translations first before it goes in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs

Projects

Status: 👍 Reviewer Approved

Development

Successfully merging this pull request may close these issues.

3 participants