Add audio transcript and video description features for a11y#5393
Add audio transcript and video description features for a11y#5393AndreaBarbasso wants to merge 1 commit intoDSpace:mainfrom
Conversation
tdonohue
left a comment
There was a problem hiding this comment.
@AndreaBarbasso : I'm starting to review this work, and I'm a little confused about the implementation that you've created, as it doesn't appear to align with the tickets #3807 and #3808:
- In #3807, we've noted that WCAG requires either an audio/video description/transcript or a full text alternative.
- In #3808 we also talk about allowing an upload of full text alternative content and labeling it appropriately
This PR appears to only add a way to create a description/transcript. It doesn't fix the issues with uploading alternative content & relating it back to the original file.
I was expecting to have two a11y features implemented:
- An option to add a description/transcript for the Bitstream (ideally in a
dc.descriptionmetadata field, as that already exists). - An option to upload a secondary file which provides a textual alternative to audio/video content.
This PR currently only implements the description/transcript feature. It doesn't allow for alternative content. So, it appears to be a partial fix for #3807 and doesn't solve #3808 at all.
My opinion is that we can simplify this PR's functionality to just have a single Description metadata field which can capture either a transcript (for audio) or a description (for video). I'm not sure that we need two separate metadata fields (description and transcript), especially if we are going to implement the alternative content upload option.
I added more feedback to the backend PR as I feel we should use existing metadata fields as much as possible.
References
Description
Added new bitstream metadata in order to include an audio transcript and/or a video description to an audio/video bitstream. Managed such metadata in submission form and bitstream edit form. Introduced modals to show those values in the item page.
Instructions for Reviewers
List of changes in this PR:
Include guidance for how to test or review your PR.
audiomedia should show the audio transcript textarea, avideomedia should show the video description textarea, and anaudio and videomedia should show both;videomedia type should not clear the audio transcript metadata value. This is expected - since these values can be quite long and tedious to write, changing the media type by accident should not clear them;Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.