Phase 2: Expand reusedCode detection to federal npm and PyPI dependencies - #126
Phase 2: Expand reusedCode detection to federal npm and PyPI dependencies#126haseebmalik18 wants to merge 6 commits into
Conversation
944d244 to
bc2a3b3
Compare
|
Not ready for review yet |
bc2a3b3 to
4170e82
Compare
|
@natalialuzuriaga Ready for review |
sachin-panayil
left a comment
There was a problem hiding this comment.
this is a great start. i left some general comments but before approving, i want to see this actually work and populate the reusedCode field in a repo. can you use testing-repo or any test repo to use this branch and actually show the reusedCode being detected and added?
… data and logic modules
4170e82 to
3043f02
Compare
|
@sachin-panayil Here is the successful run in test-repo: And the generated code.json with populated reusedCode field: |
decause-gov
left a comment
There was a problem hiding this comment.
In the interest of completing this rotation before EoW, we're going to merge this and see what happens... that's what git is for ;)
|
Something that can be a follow up is crawling through gitlab repos aswell? |
natalialuzuriaga
left a comment
There was a problem hiding this comment.
LGTM! Amazing job with phase 2
Summary
Auto-fills
code.json'sreusedCodefield with the federal dependencies detected in a repository's manifests. Phase 2 of #124.Changes
src/gov-dependencies.data.ts. Every entry maps a package to the federal repo it comes from.package.jsonand PyPI deps fromrequirements.txt, each through its own lookup since PyPI normalizes names differently.src/gov-dependencies.data.ts.src/gov-dependencies.tskeeps the lookup logic only.Note