Bugfix: Remove updates from ci#2307
Open
sandro-elsweijer wants to merge 25 commits intomainfrom
Open
Conversation
012843e to
a4cd332
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2307 +/- ##
=======================================
Coverage 82.59% 82.59%
=======================================
Files 115 115
Lines 18545 18545
=======================================
Hits 15318 15318
Misses 3227 3227 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benegee
previously approved these changes
May 6, 2026
Collaborator
benegee
left a comment
There was a problem hiding this comment.
Just some comments about things I noticed in passing.
Member
Author
|
PR is waiting for the new docker images |
benegee
previously approved these changes
May 8, 2026
e83a144 to
9b5951e
Compare
benegee
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2308
Describe your changes here:
The CI fails because the update step is sometimes so slow it triggers the time limit.
Installing packages and updating should only happen in the docker container.
Moved all packages to the docker container.
Also updated and renamed the docker containers.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
scripts/internal/find_all_source_files.shto check the indentation of these files.License
doc/(or already has one).