Skip to content

Bugfix: Remove updates from ci#2307

Open
sandro-elsweijer wants to merge 25 commits intomainfrom
fix-ci_updates
Open

Bugfix: Remove updates from ci#2307
sandro-elsweijer wants to merge 25 commits intomainfrom
fix-ci_updates

Conversation

@sandro-elsweijer
Copy link
Copy Markdown
Member

@sandro-elsweijer sandro-elsweijer commented May 5, 2026

Closes #2308

Describe your changes here:
The CI fails because the update step is sometimes so slow it triggers the time limit.
Installing packages and updating should only happen in the docker container.
Moved all packages to the docker container.
Also updated and renamed the docker containers.

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation. Make sure to add a file documentation for each file!
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the scripts/internal/find_all_source_files.sh to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@sandro-elsweijer sandro-elsweijer marked this pull request as ready for review May 5, 2026 11:14
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.59%. Comparing base (4840a9f) to head (d08b1df).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2307   +/-   ##
=======================================
  Coverage   82.59%   82.59%           
=======================================
  Files         115      115           
  Lines       18545    18545           
=======================================
  Hits        15318    15318           
  Misses       3227     3227           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

benegee
benegee previously approved these changes May 6, 2026
Copy link
Copy Markdown
Collaborator

@benegee benegee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments about things I noticed in passing.

Comment thread .github/workflows/check_doxygen.yml
Comment thread .github/workflows/check_indentation.yml
Comment thread .github/workflows/check_indentation.yml
Comment thread scripts/check_if_all_files_indented.sh Outdated
Comment thread src/t8.h Outdated
@sandro-elsweijer sandro-elsweijer requested a review from benegee May 8, 2026 13:15
@sandro-elsweijer
Copy link
Copy Markdown
Member Author

sandro-elsweijer commented May 8, 2026

PR is waiting for the new docker images

benegee
benegee previously approved these changes May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bugfix: Remove updates from ci

2 participants