Improvement: Cad geometry component test#2150
Open
sandro-elsweijer wants to merge 12 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2150 +/- ##
=======================================
Coverage 78.69% 78.70%
=======================================
Files 115 115
Lines 19206 19211 +5
=======================================
+ Hits 15115 15120 +5
Misses 4091 4091 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Davknapp
requested changes
May 12, 2026
| SC_ABORTF ("Could not read brep file or brep file contains no shape. " | ||
| "The cad file may be written with a newer cad version. " | ||
| "Linked cad version: %s", | ||
| "The cad file may be written with a newer OCC version. " |
Collaborator
There was a problem hiding this comment.
Does OCC always guarantees backward compatability?
| /* Compute the center of mass of an element. We can use the element reference | ||
| * coordinates of the centroid.*/ | ||
| void | ||
| t8_forest_element_linear_centroid (t8_forest_t forest, t8_locidx_t ltreeid, const t8_element_t *element, |
Collaborator
There was a problem hiding this comment.
Suggested change
| t8_forest_element_linear_centroid (t8_forest_t forest, t8_locidx_t ltreeid, const t8_element_t *element, | |
| t8_forest_element_linear_centroid (const t8_forest_t forest, const t8_locidx_t ltreeid, const t8_element_t *element, |
| * the x, y and z coordinates of the centroid. | ||
| */ | ||
| void | ||
| t8_forest_element_linear_centroid (t8_forest_t forest, t8_locidx_t ltreeid, const t8_element_t *element, |
Collaborator
There was a problem hiding this comment.
Suggested change
| t8_forest_element_linear_centroid (t8_forest_t forest, t8_locidx_t ltreeid, const t8_element_t *element, | |
| t8_forest_element_linear_centroid (const t8_forest_t forest, const t8_locidx_t ltreeid, const t8_element_t *element, |
| } | ||
|
|
||
| void | ||
| t8_geometry_cad::t8_geom_point_batch_inside_element (t8_forest_t forest, t8_locidx_t ltreeid, |
Collaborator
There was a problem hiding this comment.
Suggested change
| t8_geometry_cad::t8_geom_point_batch_inside_element (t8_forest_t forest, t8_locidx_t ltreeid, | |
| t8_geometry_cad::t8_geom_point_batch_inside_element (const t8_forest_t forest, const t8_locidx_t ltreeid, |
| * \param[in] tolerance Tolerance of the inside-check | ||
| */ | ||
| virtual void | ||
| t8_geom_point_batch_inside_element (t8_forest_t forest, t8_locidx_t ltreeid, const t8_element_t *element, |
Collaborator
There was a problem hiding this comment.
Suggested change
| t8_geom_point_batch_inside_element (t8_forest_t forest, t8_locidx_t ltreeid, const t8_element_t *element, | |
| t8_geom_point_batch_inside_element (const t8_forest_t forest, const t8_locidx_t ltreeid, const t8_element_t *element, |
| * \param [in] tolerance The tolerance | ||
| * \return true if points are coplanar. | ||
| */ | ||
| int |
Collaborator
There was a problem hiding this comment.
Suggested change
| int | |
| constexpr int |
| * \param [in] tolerance The tolerance | ||
| * \return true if points are coplanar. | ||
| */ | ||
| int |
Collaborator
There was a problem hiding this comment.
Suggested change
| int | |
| constexpr int |
Collaborator
There was a problem hiding this comment.
All the point operations should be constexpr, therefore this should be possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes here:
This PR adds a cad geometry component test. It refines a curved base forest and checks if it matches a target forest. This tests the msh reader as well as the cad geometries.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).