fix(routers): parse If-Modified-Since as GMT and extract apply_cache_headers#937
Open
chrisburr wants to merge 1 commit into
Open
fix(routers): parse If-Modified-Since as GMT and extract apply_cache_headers#937chrisburr wants to merge 1 commit into
chrisburr wants to merge 1 commit into
Conversation
…headers The If-Modified-Since header is always GMT (RFC 9110) but it was parsed with astimezone(), which interprets the naive datetime as server-local time. Use replace(tzinfo=timezone.utc) instead. The conditional-request logic (ETag / Last-Modified / 304) is moved out of the configuration router into a reusable apply_cache_headers helper. Co-authored-by: Loxeris <30194187+Loxeris@users.noreply.github.com>
5 tasks
Loxeris
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
If-Modified-Sinceheader is always GMT (RFC 9110) but it was parsed withastimezone(), which interprets the naive datetime as server-local time. Usereplace(tzinfo=timezone.utc)instead.The conditional-request logic (ETag / Last-Modified / 304) is moved out of the configuration router into a reusable
apply_cache_headershelper.Replaces #910
Part of #839