[int] Move watchdog flag cleanup to correct place#8619
Open
sfayer wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test fixup that I added isn't in the right place: It works for the "runslow" tests because the slow test with the cleanup runs after the test that creates it. In "fast" mode, the file still gets left behind: This patch puts the cleanup in the test that actually creates the file (really it could still do with being a test fixture so that it runs whatever state the test finishes in, but that also feels like a lot of extra code for this one file that doesn’t seem to annoy anyone else :-)
BEGINRELEASENOTES
*WorkloadManagement
FIX: Move watchdog flag cleanup to correct place
ENDRELEASENOTES