fix: install non-released versions: handle space#8505
fix: install non-released versions: handle space#8505fstagni wants to merge 1 commit intoDIRACGrid:integrationfrom
Conversation
| self.log.info("Downloaded DIRACOS installer to", installer.name) | ||
|
|
||
| directory = version if released_version else version.split("@")[1].split("#")[0] | ||
| directory = version if released_version else version.split()[2].split("@")[1].split("#")[0] |
There was a problem hiding this comment.
Ins't .replace(' ','') safer as I naively would never have put any space there
There was a problem hiding this comment.
The space now is always present, since #8496
There was a problem hiding this comment.
I am not entirely sure space is always present actually: https://packaging.python.org/en/latest/specifications/dependency-specifiers/#whitespace
There was a problem hiding this comment.
So, I corrected accordingly. Thank you!
| self.log.info("Downloaded DIRACOS installer to", installer.name) | ||
|
|
||
| directory = version if released_version else version.split("@")[1].split("#")[0] | ||
| directory = version if released_version else version.split()[2].split("@")[1].split("#")[0] |
There was a problem hiding this comment.
I am not entirely sure space is always present actually: https://packaging.python.org/en/latest/specifications/dependency-specifiers/#whitespace
| update <version> | ||
| """ | ||
| try: | ||
| version = args.split()[0] |
There was a problem hiding this comment.
Don't you need to keep args.split() to verify args is not ""?
There was a problem hiding this comment.
Oops I actually meant strip sorry, to have:
version = args.strip()
if not version:
gLogger.notice(...)
...
return
result = client.updateSoftware(version, timeout=600)Because in the documentation you removed the quotes, so I guess you need to remove args.split()[0], or else you would only have DIRAC[server] for instance. Am I wrong?
fstagni
force-pushed
the
fix_install_not_release
branch
from
0c50ab0 to
62a8d63
Compare
fstagni
force-pushed
the
fix_install_not_release
branch
from
62a8d63 to
475534f
Compare
3 participants
No description provided.