Legg til sidenavigering i bottomsheet og legg til muligheten for stroke rundt checkmark#881
Open
eirinsvi wants to merge 28 commits into
Open
Legg til sidenavigering i bottomsheet og legg til muligheten for stroke rundt checkmark#881eirinsvi wants to merge 28 commits into
eirinsvi wants to merge 28 commits into
Conversation
…e to checkmark property
Contributor
There was a problem hiding this comment.
Pull request overview
Adds two new capabilities to the DIPS.Mobile.UI component library: (1) an internal navigation stack for BottomSheet (Push/Pop between sub-views) with optional persistent bottom bar buttons across pushed views, and (2) an AddStrokeToCheckmark option for Checkmark and CheckmarkListItem to render an outline around the checkmark.
Changes:
- BottomSheet: Introduces
PushAsync/PopAsyncnavigation, Android transition-based navigation container + updated header toolbar behavior, and iOS navigation via pushed view controllers. - Selection: Adds
AddStrokeToCheckmarkbindable properties and sample usage forCheckmark+CheckmarkListItem. - Docs/Samples/Tests: Updates BottomSheet wiki + changelog, adds a navigation sample sheet, and extends MemoryLeakTests coverage.
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| wiki/Layout & Navigation/Bottom-sheet.md | Documents persistent bottom bar buttons across pushed sub-views. |
| src/library/DIPS.Mobile.UI/Resources/Icons/Android/Icons.cs | Fixes TryGetDrawable to respect the requested iconName. |
| src/library/DIPS.Mobile.UI/Components/Selection/Checkmark.Properties.cs | Adds AddStrokeToCheckmark bindable property (public API). |
| src/library/DIPS.Mobile.UI/Components/Selection/Checkmark.cs | Applies/removes stroke when AddStrokeToCheckmark changes. |
| src/library/DIPS.Mobile.UI/Components/ListItems/Extensions/CheckmarkListItem.Properties.cs | Adds AddStrokeToCheckmark bindable property (public API). |
| src/library/DIPS.Mobile.UI/Components/ListItems/Extensions/CheckmarkListItem.cs | Applies/removes stroke on the list item’s checkmark icon. |
| src/library/DIPS.Mobile.UI/Components/BottomSheets/iOS/BottomSheetViewController.cs | Hosts bottom bar differently to keep it visible across pushed sub-views + ensures z-order after push. |
| src/library/DIPS.Mobile.UI/Components/BottomSheets/iOS/BottomSheetNavigationContentViewController.cs | New iOS VC to host pushed MAUI content with nav bar appearance + close behavior. |
| src/library/DIPS.Mobile.UI/Components/BottomSheets/iOS/BottomSheet.cs | iOS platform PushAsync/PopAsync implementation. |
| src/library/DIPS.Mobile.UI/Components/BottomSheets/iOS/BottomBarView.cs | Adjusts bottom bar hosting behavior and constraint setup. |
| src/library/DIPS.Mobile.UI/Components/BottomSheets/dotnet/BottomSheet.cs | Adds dotnet stubs for new partial navigation methods. |
| src/library/DIPS.Mobile.UI/Components/BottomSheets/BottomSheetNavigationEntry.cs | Introduces internal navigation entry record. |
| src/library/DIPS.Mobile.UI/Components/BottomSheets/BottomSheet.Properties.cs | Adds ShowBottombarButtonsOnSubViews property (public API). |
| src/library/DIPS.Mobile.UI/Components/BottomSheets/BottomSheet.cs | Adds PushAsync/PopAsync, managed NavigationStack, and interactive pop sync hook. |
| src/library/DIPS.Mobile.UI/Components/BottomSheets/Android/BottomSheetHeader.cs | Removes prior Android header view implementation. |
| src/library/DIPS.Mobile.UI/Components/BottomSheets/Android/BottomSheetHandler.cs | Replaces header view with MaterialToolbar, adds native navigation container + transitions, and back interception. |
| src/library/DIPS.Mobile.UI/Components/BottomSheets/Android/BottomSheet.cs | Android platform PushAsync/PopAsync implementation. |
| src/app/MemoryLeakTests/Tests/TestRegistrator.cs | Registers new BottomSheet memory leak test. |
| src/app/MemoryLeakTests/Tests/BottomSheetTests.cs | Expands leak test to cover PushAsync + persistent bottom bar scenario. |
| src/app/Components/ComponentsSamples/Selection/SelectionSamples.xaml | Adds sample usage for checkmark stroke options. |
| src/app/Components/ComponentsSamples/BottomSheets/Sheets/BottomSheetWithNavigation.xaml(.cs) | Adds a sample BottomSheet demonstrating in-sheet navigation. |
| src/app/Components/ComponentsSamples/BottomSheets/BottomSheetSamples.xaml | Adds entry point to open the navigation sample. |
| CHANGELOG.md | Adds 60.2.0 release notes for BottomSheet navigation + checkmark stroke. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Vetle444
reviewed
May 29, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…AS/DIPS.Mobile.UI into vefi/bottomSheetNavigation2
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…AS/DIPS.Mobile.UI into vefi/bottomSheetNavigation2
…AS/DIPS.Mobile.UI into vefi/bottomSheetNavigation2
Vetle444
reviewed
Jun 2, 2026
Vetle444
reviewed
Jun 2, 2026
Contributor
Author
|
Venter med å ta inn til etter 4.7 |
…AS/DIPS.Mobile.UI into vefi/bottomSheetNavigation2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
AddStrokeToCheckmarkproperty to display a visible stroke around the checkmarkAddStrokeToCheckmarkproperty to display a visible stroke around the checkmark iconTodos