Skip to content

Properly Reimpelement Localization - #217

Open
Setnour6 wants to merge 3 commits into
masterfrom
hotfix/Localization
Open

Properly Reimpelement Localization#217
Setnour6 wants to merge 3 commits into
masterfrom
hotfix/Localization

Conversation

@Setnour6

@Setnour6 Setnour6 commented Aug 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Reimplement the en_US localization to the new localization file in preparation for a potential second demo release.

Copy from Everglow\Resources\Localization\zh_Hans.hjson.
Paste to Everglow\Localization\zh_Hans.Mods.Everglow.hjson.

I also changed the name of some text by fixing typos, removing unrequired texts, and so on.

@Setnour6
Properly Reimpelement en_US Localization
92c8b90 
I also changed the name of some text by fixing typos, removing unrequired texts, and so on.
@Setnour6 Setnour6 added enhancement New feature or request priority: medium This might be considered or being worked on priority type: pre-release This should be considered or worked on before release [Temporary Label] labels Aug 21, 2023
@Setnour6
Setnour6 requested a review from lace-wing August 21, 2023 22:50
lace-wing
lace-wing requested changes Nov 15, 2023
View reviewed changes

@lace-wing lace-wing left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat. Can you fix the multiline quote (''') indentations and try compiling to see if it works?

@Setnour6

Setnour6 commented Nov 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Looks neat. Can you fix the multiline quote (''') indentations and try compiling to see if it works?

Sure! I can't build it though due to the new TileDrawing changes and error MSB4063 & MSB4064, the PackageReference not supported errors and PublicizeTask errors.

@Felixyang777

Felixyang777 commented Dec 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Looks neat. Can you fix the multiline quote (''') indentations and try compiling to see if it works?

Sure! I can't build it though due to the new TileDrawing changes and error MSB4063 & MSB4064, the PackageReference not supported errors and PublicizeTask errors.

These errors are fixed by merging the mater ,but there are still problems with the text display

@Setnour6

Setnour6 commented Dec 16, 2023

Copy link
Copy Markdown
Collaborator Author

These errors are fixed by merging the mater ,but there are still problems with the text display

I'm using a separate mod for localization since the current localizations keep resetting.

@lace-wing

lace-wing commented Feb 22, 2024

Copy link
Copy Markdown
Collaborator

Just relooked into the changes, I believe that as long as the conflicts are resolved, this can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lace-wing lace-wing lace-wing requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@lace-wing lace-wing

Labels

enhancement New feature or request priority: medium This might be considered or being worked on priority type: pre-release This should be considered or worked on before release [Temporary Label]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Setnour6 @Felixyang777 @lace-wing