Skip to content

test(e2e): stop bounding assertions by idle-machine wall clock #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Antisophy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test(e2e): stop bounding assertions by idle-machine wall clock #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions tests/e2e/agent-type-change.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ async function waitForNewTid(page: Page, before: Set<string>): Promise<string> {
);
newTid = tids.find((tid: string) => !before.has(tid));
expect(newTid).toBeTruthy();
}).toPass({ timeout: 5_000 });
}).toPass();
return newTid!;
}

Expand Down Expand Up @@ -62,8 +62,7 @@ test("changing agent type after draft creation updates backend", async ({

// Agent picker should be visible in draft mode
await expect(page.locator(".agent-picker")).toBeVisible({
timeout: 5_000,
});
});

const before = await snapshotTids(page);

Expand All @@ -76,7 +75,7 @@ test("changing agent type after draft creation updates backend", async ({
const draftTid = await waitForNewTid(page, before);
await expect(
page.locator(`.sidebar-item[data-tid="${draftTid}"] .draft-label`),
).toBeVisible({ timeout: 2_000 });
).toBeVisible();

// Change the agent picker to a different agent
await page.locator(".agent-picker").selectOption(targetAgent);
Expand Down
10 changes: 3 additions & 7 deletions tests/e2e/archive.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,8 +217,7 @@ test("archived task cannot be resumed without unarchiving", async ({
await resumeBtn.click();
// The task must NOT become alive (stop button must not appear)
await expect(page.locator(".btn-banner-stop")).not.toBeVisible({
timeout: 3_000,
});
});
await expect(resumeBtn).toBeVisible();
}
});
Expand All @@ -244,12 +243,9 @@ test("URL routing for archive nodes", async ({ page, agentType }) => {
await page.reload();

// Archive node must still be selected after reload
await expect(page.locator(".sidebar-archive-node")).toHaveClass(/active/, {
timeout: 15_000,
});
await expect(page.locator(".sidebar-archive-node")).toHaveClass(/active/);

// Archive placeholder must be shown (not "Loading task...")
await expect(page.locator(".archive-placeholder")).toBeVisible({
timeout: 15_000,
});
});
});
Loading