Skip to content

fix(native): enforce ARI request timeout - #193

Open
vshapovalov-basip wants to merge 1 commit into
CyCoreSystems:mainfrom
basip:fix/ari-request-timeout
Open

fix(native): enforce ARI request timeout#193
vshapovalov-basip wants to merge 1 commit into
CyCoreSystems:mainfrom
basip:fix/ari-request-timeout

Conversation

@vshapovalov-basip

@vshapovalov-basip vshapovalov-basip commented Aug 3, 2026

Copy link
Copy Markdown

This change is Reviewable

Comment thread client/native/client.go

// RequestTimeout limits the complete lifetime of an ARI REST request.
// The package RequestTimeout value is used when this is not positive.
RequestTimeout time.Duration

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A far more flexible solution to this problem would instead be to accept a custom http.Client, which would then be able to handle all manner of other types of options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants