feat: add WaitFor condition waits#255
Merged
Jeomon merged 1 commit intoMay 21, 2026
Merged
Conversation
Agents can now wait for common UI readiness signals inside one tool call, using the existing desktop state capture path and a bounded polling loop. Constraint: Issue CursorTouch#87 discussion prioritizes condition waits with a small polling fallback. Rejected: Event-driven WatchDog wakeups in this PR | polling contract keeps the contribution narrow. Confidence: high Scope-risk: narrow Directive: Preserve WaitFor inputs and timeout semantics when adding WatchDog wakeups. Tested: uv run ruff check src/windows_mcp/tools/input.py tests/test_wait_for_tool.py README.md; uv run python -m pytest tests/test_wait_for_tool.py tests/test_multi_tools.py; uv run python -m pytest (304 passed, 6 existing tests/test_tree_views.py failures observed) Not-tested: Repository-wide green pytest run; current run reports the existing tests/test_tree_views.py failures.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Addresses #87.
Summary
WaitForfor condition-based UI readiness waits inside one tool call.Desktop.get_statewith bounded polling and DOM opt-in for browser text.Duplicate check
Open PR search for WaitFor / condition waits found the unrelated window-targeted screenshot PR #233.
Testing
uv run ruff check src/windows_mcp/tools/input.py tests/test_wait_for_tool.py README.mduv run python -m pytest tests/test_wait_for_tool.py tests/test_multi_tools.py-> 9 passeduv run python -m pytest-> 304 passed, 6 existingtests/test_tree_views.pyfailures; existing flash overlay access violation stack observed