Skip to content

fix(opencode): create root span per prompt for OTEL trace isolation #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CreatorGhost merged 2 commits into from
Jul 12, 2026
+19 −1
Merged

fix(opencode): create root span per prompt for OTEL trace isolation #31

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
811a590
fix(opencode): create root span per prompt for OTEL trace isolation
CreatorGhost Jul 11, 2026
feecef4
fix(opencode): attach invoke_agent root span to forked work
CreatorGhost Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion packages/opencode/src/session/prompt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1361,7 +1361,25 @@ const layer = Layer.effect(
const loop: (input: LoopInput) => Effect.Effect<SessionV1.WithParts> = Effect.fn("SessionPrompt.loop")(function* (
input: LoopInput,
) {
return yield* state.ensureRunning(input.sessionID, lastAssistant(input.sessionID), runLoop(input.sessionID))
// Wrap the forked work (runLoop) — not the ensureRunning caller — so every
// prompt (idle or queued/steered) gets its own root trace and its child spans
// are parented correctly. ensureRunning may store `work` and start it later
// from a prior run's fiber, so a span on the caller would mis-parent queued
// prompts and measure queue-wait instead of the agent turn.
return yield* state.ensureRunning(
input.sessionID,
lastAssistant(input.sessionID),
runLoop(input.sessionID).pipe(
Effect.withSpan("invoke_agent", {
root: true,
attributes: {
"gen_ai.operation.name": "invoke_agent",
"gen_ai.conversation.id": input.sessionID,
"session.id": input.sessionID,
},
}),
),
)
})

const shell: (input: ShellInput) => Effect.Effect<SessionV1.WithParts, Session.BusyError> = Effect.fn(
Expand Down
Loading