Skip to content

Add support for nullable enums to cli options parsing #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
darthsharp merged 1 commit into from
Feb 14, 2026
Merged

Add support for nullable enums to cli options parsing #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...e/SysConsole/CreativeCoders.SysConsole.Cli.Parsing/OptionProperties/CliValueConverters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,14 @@ private CliValueConverters()
return boolValue;
}

var valueConverted = InternalConvert(value, nullableType, optionAttribute);
var valueConverted = nullableType.IsEnum
? _enumConverter.Convert(value, nullableType, optionAttribute)
: InternalConvert(value, nullableType, optionAttribute);

if (valueConverted == ConverterAction.DoNothing)
{
return ConverterAction.DoNothing;
}

return valueConverted == null
? Activator.CreateInstance(targetType)
Expand Down
52 changes: 52 additions & 0 deletions tests/CreativeCoders.SysConsole.Cli.Parsing.UnitTests/OptionParserTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,58 @@ public void Parse_EnumValue_PropertyIsSetCorrect(string argValue, TestEnum enumV
.Be(enumValue);
}

[Theory]
[InlineData("Ok", TestEnum.Ok)]
[InlineData("OK", TestEnum.OK)]
[InlineData("ok", null)]
[InlineData("", null)]
[InlineData("Default", TestEnum.Default)]
[InlineData("default", TestEnum.Default)]
[InlineData("Custom", TestEnum.Custom)]
[InlineData("CUSTOM", TestEnum.Custom)]
[InlineData("Failed", TestEnum.Failed)]
[InlineData("failED", TestEnum.Failed)]
[InlineData("None", TestEnum.None)]
[InlineData("nONe", TestEnum.None)]
public void Parse_NullableEnumValue_PropertyIsSetCorrect(string argValue, TestEnum? enumValue)
{
var args = new[] { "-ne", argValue };

var parser = new OptionParser(typeof(TestOptionWithEnum));

// Act
var option = parser.Parse(args) as TestOptionWithEnum;

// Assert
option
.Should()
.NotBeNull();

option.NullableEnumValue
.Should()
.Be(enumValue);
}

[Fact]
public void Parse_NotGivenNullableEnumValue_PropertyIsNull()
{
var args = Array.Empty<string>();

var parser = new OptionParser(typeof(TestOptionWithEnum));

// Act
var option = parser.Parse(args) as TestOptionWithEnum;

// Assert
option
.Should()
.NotBeNull();

option.NullableEnumValue
.Should()
.Be(null);
}

[Theory]
[InlineData("Hello", "World")]
[InlineData("World", "Hello")]
Expand Down
3 changes: 3 additions & 0 deletions tests/CreativeCoders.SysConsole.Cli.Parsing.UnitTests/TestData/TestOptionWithEnum.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,7 @@ namespace CreativeCoders.SysConsole.Cli.Parsing.UnitTests.TestData;
public class TestOptionWithEnum
{
[OptionParameter('e', "enum")] public TestEnum EnumValue { get; set; }

[OptionParameter("ne", "nullableenum")]
public TestEnum? NullableEnumValue { get; set; }
}