Add multi char support for short names in cli options#74
Merged
darthsharp merged 3 commits intomainfrom Jan 31, 2026
Merged
Conversation
…ames and update related tests for validation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for multi-character short names in CLI option parameters. Previously, short names were limited to single characters (e.g., -t), but now they can be multiple characters (e.g., -te). The implementation changes the ShortName property type from char? to string? in OptionParameterAttribute while maintaining backward compatibility through constructor overloads.
Changes:
- Modified
OptionParameterAttributeto accept string short names instead of char, with backward-compatible constructors - Updated
OptionParameterPropertycomparison logic to work with string short names - Added test case demonstrating multi-character short name functionality
- Refactored code to use primary constructors and modern C# syntax (collection expressions, removed null-forgiving operators)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| TestOptionForParser.cs | Added test property using multi-character short name "te" |
| OptionParserTests.cs | Added test for multi-char short names; cleaned up null-forgiving operators and modernized collection syntax |
| OptionParameterProperty.cs | Removed ToString() call on ShortName comparison; refactored to primary constructor |
| OptionParameterAttribute.cs | Changed ShortName from char? to string?; added string constructor overload |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…-character short names.
darthsharp
changed the title
…Attribute` using `Ensure.IsNotNullOrWhitespace`. Update related test data for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.