Skip to content

Address Mypy Errors#798

Open
MattToast wants to merge 3 commits intoCrayLabs:developfrom
MattToast:mypy-errs
Open

Address Mypy Errors#798
MattToast wants to merge 3 commits intoCrayLabs:developfrom
MattToast:mypy-errs

Conversation

@MattToast
Copy link
Copy Markdown
Member

Mypy got smarter in later releases and started pointing out some potential type errors in SmartSim. This is a quick PR to address/suppress them.

@MattToast MattToast requested a review from ashao April 20, 2026 23:42
@MattToast MattToast self-assigned this Apr 20, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.17%. Comparing base (d7d979e) to head (1a47a2b).
⚠️ Report is 26 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #798      +/-   ##
===========================================
- Coverage    83.91%   80.17%   -3.74%     
===========================================
  Files           83       78       -5     
  Lines         6284     6093     -191     
===========================================
- Hits          5273     4885     -388     
- Misses        1011     1208     +197     
Files with missing lines Coverage Δ
smartsim/entity/model.py 96.04% <100.00%> (-0.04%) ⬇️

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MattToast MattToast added the release:052026 To be addressed as part of the May 2026 maintenance release label Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:052026 To be addressed as part of the May 2026 maintenance release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant