Skip to content

Unify uninstall confirmation flag help #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GreyforgeLabs wants to merge 1 commit into from
Closed

Unify uninstall confirmation flag help #379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/cortex-cli/src/uninstall_cmd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,10 @@ pub struct UninstallCli {
#[arg(long)]
pub dry_run: bool,

/// Skip confirmation prompt
#[arg(long, short = 'f')]
pub force: bool,

/// Auto-confirm (alias for --force)
#[arg(long, short = 'y')]
/// Skip confirmation prompt.
///
/// Aliases: --force, -f (for compatibility)
#[arg(long = "yes", short = 'y', visible_aliases = ["force"], short_alias = 'f')]
pub yes: bool,

/// Create backup before uninstalling
Expand Down Expand Up @@ -182,7 +180,7 @@ impl UninstallCli {
}

// Confirm before proceeding (Issue #3682: confirm BEFORE creating backup)
if !self.force && !self.yes {
if !self.yes {
println!("\nAre you sure you want to uninstall Cortex CLI? [y/N]");
if !prompt_yes_no()? {
println!("Uninstall cancelled.");
Expand All @@ -195,7 +193,7 @@ impl UninstallCli {
print_info("Creating backup...");
if let Err(e) = create_backup(&items_to_remove) {
print_warning(&format!("Failed to create backup: {e}"));
if !self.force && !self.yes {
if !self.yes {
println!("Continue without backup? [y/N]");
if !prompt_yes_no()? {
print_info("Uninstall cancelled.");
Expand Down