feat(ci): run docker:// container actions#381
Merged
Conversation
🍊 Orange Codens レビュー指摘事項はありません。✨ head: |
`uses: docker://<image>` steps now execute instead of being skipped. The image
runs with the job workspace bind-mounted, network isolated, and the step's
`with:` inputs passed as GitHub-style INPUT_* env vars (uppercased, non-alnum
to underscore, ${{ }} interpolated). Output is captured as job log lines
(secret-masked) and a non-zero exit fails the job. The container runner is
injectable for tests.
Non-checkout, non-docker actions (JS/marketplace actions, which require the
full Actions runtime) remain logged as unsupported and skipped without failing
the run.
Verified live: `uses: docker://og-test-action:latest` with
`with: {greeting: hello-from-workflow, my-name: ${{ github.actor }}}` runs the
container and logs `greeting=hello-from-workflow name=alice` (dash normalized,
actor interpolated); a following run step still executes.
836d79c to
2a83fc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uses: docker://<image>steps now execute instead of being skipped — the oneuses:category that's self-contained (no Actions JS toolkit needed).Behavior
/github/workspace), network isolated (--network none), and the step'swith:inputs passed as GitHub-styleINPUT_*env vars (uppercased, non-alphanumeric →_,${{ }}interpolated).JS/marketplace actions (which need the full Actions runtime + action registry) remain logged as unsupported and skipped without failing the run — a deliberate scope boundary.
Verified live
uses: docker://og-test-action:latestwithwith: {greeting: hello-from-workflow, my-name: ${{ github.actor }}}:Unit tests cover input env construction (incl. dash normalization), image extraction, and failure handling with an injected runner.