feat(ci): honor job-level if: conditions#379
Merged
Merged
Conversation
Step-level `if:` was evaluated but job-level `if:` was ignored, so a gated job (e.g. `if: github.ref_name == 'main'` on a deploy job) always ran. Carry the job's `if` into the IR and evaluate it in the run loop: a false condition marks the whole job skipped (status completed / conclusion skipped), like GitHub. The needs-skip and if-skip paths now share one skipJob helper. Verified live: a `deploy` job with `if: github.ref_name == 'main'` runs on main while a sibling with `if: github.ref_name == 'nope'` is skipped; a full workflow exercising matrix + checkout + env + expressions + needs + job-if + masked secrets all behave correctly.
🍊 Orange Codens レビュー🔒 セキュリティ: 本PRはジョブレベルの 指摘事項はありません。✨ head: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step-level
if:was evaluated but job-levelif:was ignored, so a gated job (e.g.if: github.ref_name == 'main'on a deploy job) always ran.Carry the job's
ifinto the IR and evaluate it in the run loop: a false condition marks the whole job skipped (status completed / conclusion skipped), like GitHub. The needs-skip and if-skip paths now share oneskipJobhelper.Verified live with a full workflow exercising matrix + actions/checkout + env +
${{ }}expressions + needs + job-level if + masked secrets: