Pin the formatter, and stop format-gating generated migrations - #267
Merged
Conversation
`@biomejs/biome` was a caret range, so a release changed what CI considered correctly formatted without anybody committing anything. Main has been red since 2.5.10 landed, and so is every branch opened against it. A formatter whose verdict moves on its own is not a check. Pinned to the version already in the lockfile, with the schema reference and the nine files it wants brought into line. `server/drizzle` is generated by drizzle-kit and now excluded. Reformatting a migration snapshot is a diff of hundreds of lines that says nothing, on files whose whole point is that they match what the tool wrote.
davidmckayv
requested review from
MikeRyanDev,
guidovizoso and
tylerslaton
as code owners
August 26, 2026 21:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main has been red since Biome 2.5.10 landed:
@biomejs/biomewas a caret range, so a release changed what CI considers correctly formatted without anybody committing anything. Every branch opened against main fails the same check.Pinned to the version already in the lockfile, with the schema reference and the nine files it wants brought into line.
server/drizzleis generated by drizzle-kit and now excluded from formatting. Reformatting a migration snapshot is a few hundred lines of diff that says nothing, on files whose whole point is that they match what the tool wrote.