Alarm server: Allow multiple -settings#3849
Conversation
Just like the phoebus GUI, it should allow multiple settings, like alarm-server -settings /path/to/global/settings.ini -settings /path/to/more/specific/settings.ini
|
|
The alarm server actually allowed multiple -settings until a9e6473c8b, and since we had an operational alarm server in place since 2022, we only noticed now that multiple -settings had been broken |
|
In this situation, each successive settings is of higher priority and would override any duplicate preferences from the previous settings file? While not a fan of ordered arguments, I would think the global preferences are packaged with the site specific product and a single setting file would be enough to override the specific preferences based on deployment details. However, since we have this feature could we consider a core settings utility service? It would be easier to have unit tests to prevent this for happening again. |
|
Feel free to re-package this, but we do rely on the end result of supporting multiple The alternative would be about 30 different products, which doesn't seem practical. After all, people tend to not build many site-specific copies of |
|
I understand the usecase we did 2 products
This was just an FYI, my main goal here would be add tests so that we don't accidentally break this in the future |



Just like the phoebus GUI, it should allow multiple settings, like
alarm-server -settings /path/to/global/settings.ini -settings /path/to/more/specific/settings.iniFixes #3848
Before this fix,
alarm-server -settings /path/to/global/settings.ini -settings /path/to/more/specific/settings.iniwould ignore the global settings. Now it loads global and then specific settings.
Before this fix
alarm-server -settings MISSING_FILE.ini -settings /path/to/existing/settings.iniwould not notice the missing file because it ignored all but the last settings.
Now it will load all provided settings in the listed order and notice the missing file.