π§ͺ [ν μ€νΈ κ°μ ] sanitizeHandleId μ£μ§ μΌμ΄μ€ ν μ€νΈ μΆκ° λ° μ κ·μ μ μ© - #821
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: π Files selected for processing (1)
π WalkthroughWalkthrough
ChangesνΈλ€ ID μ μ κ²μ¦
Estimated code review effort: 2 (Simple) | ~10 minutes π₯ Pre-merge checks | β 5β Passed checks (5 passed)
β¨ Finishing Touchesπ Generate docstrings
π§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
π€ Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/erd/handleUtils.test.ts`:
- Around line 6-19: Update the test cases in the sanitizeHandleId parameterized
table to expect the actual hexadecimal Unicode-scalar encoding with the c-
prefix, using src-c- and tgt-c- forms where applicable. Replace the empty-string
expectation with c-empty and revise every listed input, including the cases
referenced around lines 25β31, to match sanitizeHandleIdβs returned format.
πͺ Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
βΉοΈ Review info
βοΈ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: b848f00b-7850-4c12-a93c-f75fd746161d
π Files selected for processing (2)
.jules/bolt.mdfrontend/src/erd/handleUtils.test.ts
|
Superseded by #786 at exact head |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
π― What:
sanitizeHandleIdν¨μμ λ€μν μ£μ§ μΌμ΄μ€(곡백, νΉμλ¬Έμ, μ΄λͺ¨μ§ λ±)μ λν ν μ€νΈ λλ½μ 보μνκ³ , μ΄μ μ λλ½λμλ μ κ·μ κΈ°λ° μΉν λ‘μ§μ μ¬λ°λ₯΄κ² 볡μνμ΅λλ€.π Coverage:
sanitizeHandleIdν μ€νΈλ₯Όit.eachν μ΄λΈ λ°©μμΌλ‘ 리ν©ν λ§νμ¬ μμ«μ, 곡백, μ λμ½λ, ZWJ μ΄λͺ¨μ§, μ μ΄ λ¬Έμ λ±μ ν¬κ΄μ μΌλ‘ ν μ€νΈν©λλ€.coverageEdges.test.tsλ°mermaid.test.tsλ± μμ‘΄μ± ν μ€νΈμμλ μμ λ νΈλ€ νμμ μ¬μ©νλλ‘ μ λ°μ΄νΈνμ΅λλ€.β¨ Result: νΈλ€ μμ± λ‘μ§μ μμ μ±μ ν보νκ³ ν₯ν μ μ§λ³΄μ μ νμ νΈνμ±μ 보μ₯νλ κ²¬κ³ ν ν μ€νΈ νκ²½μ λ§λ ¨νμ΅λλ€.
PR created automatically by Jules for task 12233152362821265480 started by @seonghobae
Summary by CodeRabbit
ν μ€νΈ
λ¬Έμ