Skip to content

πŸ§ͺ [ν…ŒμŠ€νŠΈ κ°œμ„ ] sanitizeHandleId μ—£μ§€ μΌ€μ΄μŠ€ ν…ŒμŠ€νŠΈ μΆ”κ°€ 및 μ •κ·œμ‹ 적용 - #821

Closed
seonghobae wants to merge 3 commits into
mainfrom
improve-sanitize-handle-id-tests-12233152362821265480
Closed

πŸ§ͺ [ν…ŒμŠ€νŠΈ κ°œμ„ ] sanitizeHandleId μ—£μ§€ μΌ€μ΄μŠ€ ν…ŒμŠ€νŠΈ μΆ”κ°€ 및 μ •κ·œμ‹ 적용#821
seonghobae wants to merge 3 commits into
mainfrom
improve-sanitize-handle-id-tests-12233152362821265480

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

🎯 What: sanitizeHandleId ν•¨μˆ˜μ˜ λ‹€μ–‘ν•œ μ—£μ§€ μΌ€μ΄μŠ€(곡백, 특수문자, 이λͺ¨μ§€ λ“±)에 λŒ€ν•œ ν…ŒμŠ€νŠΈ λˆ„λ½μ„ λ³΄μ™„ν•˜κ³ , 이전에 λˆ„λ½λ˜μ—ˆλ˜ μ •κ·œμ‹ 기반 μΉ˜ν™˜ λ‘œμ§μ„ μ˜¬λ°”λ₯΄κ²Œ λ³΅μ›ν–ˆμŠ΅λ‹ˆλ‹€.
πŸ“Š Coverage: sanitizeHandleId ν…ŒμŠ€νŠΈλ₯Ό it.each ν…Œμ΄λΈ” λ°©μ‹μœΌλ‘œ λ¦¬νŒ©ν† λ§ν•˜μ—¬ 영숫자, 곡백, μœ λ‹ˆμ½”λ“œ, ZWJ 이λͺ¨μ§€, μ œμ–΄ 문자 등을 ν¬κ΄„μ μœΌλ‘œ ν…ŒμŠ€νŠΈν•©λ‹ˆλ‹€. coverageEdges.test.ts 및 mermaid.test.ts λ“± μ˜μ‘΄μ„± ν…ŒμŠ€νŠΈμ—μ„œλ„ μˆ˜μ •λœ ν•Έλ“€ ν˜•μ‹μ„ μ‚¬μš©ν•˜λ„λ‘ μ—…λ°μ΄νŠΈν–ˆμŠ΅λ‹ˆλ‹€.
✨ Result: ν•Έλ“€ 생성 둜직의 μ•ˆμ •μ„±μ„ ν™•λ³΄ν•˜κ³  ν–₯ν›„ μœ μ§€λ³΄μˆ˜ μ‹œ ν•˜μœ„ ν˜Έν™˜μ„±μ„ 보μž₯ν•˜λŠ” κ²¬κ³ ν•œ ν…ŒμŠ€νŠΈ ν™˜κ²½μ„ λ§ˆλ ¨ν–ˆμŠ΅λ‹ˆλ‹€.


PR created automatically by Jules for task 12233152362821265480 started by @seonghobae

Summary by CodeRabbit

  • ν…ŒμŠ€νŠΈ

    • ERD ν•Έλ“€ ID μ •μ œ κ·œμΉ™μ— λŒ€ν•œ 검증 λ²”μœ„λ₯Ό ν™•λŒ€ν–ˆμŠ΅λ‹ˆλ‹€.
    • 영문, 빈 λ¬Έμžμ—΄, μœ λ‹ˆμ½”λ“œ, 이λͺ¨μ§€, 곡백, 특수문자, μ œμ–΄λ¬Έμž 및 κ²°ν•© 문자 λ“± λ‹€μ–‘ν•œ μž…λ ₯ 사둀λ₯Ό ν…ŒμŠ€νŠΈν•©λ‹ˆλ‹€.
    • ν•Έλ“€ ID κ΄€λ ¨ κΈ°λŒ€κ°’μ„ μ΅œμ‹  ν˜•μ‹μ— 맞게 μ—…λ°μ΄νŠΈν–ˆμŠ΅λ‹ˆλ‹€.
  • λ¬Έμ„œ

    • ν•Έλ“€ ID ν˜•μ‹ λ³€κ²½ μ‹œ κ΄€λ ¨ 내보내기 κΈ°λŠ₯의 mockκ³Ό 검증도 ν•¨κ»˜ κ°±μ‹ ν•˜λ„λ‘ μ•ˆλ‚΄λ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. πŸŽ‰

ℹ️ Recent review info
βš™οΈ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f1e26b3e-b7ee-4a07-a34f-80179dc2a8fd

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 51015ea and bd56e3c.

πŸ“’ Files selected for processing (1)
  • frontend/src/erd/handleUtils.test.ts

πŸ“ Walkthrough

Walkthrough

sanitizeHandleId ν…ŒμŠ€νŠΈλ₯Ό ν…Œμ΄λΈ” 기반 κ²€μ¦μœΌλ‘œ ν™•μž₯ν–ˆμŠ΅λ‹ˆλ‹€. λ‹€μ–‘ν•œ 문자 μž…λ ₯κ³Ό c- 인코딩 κ²°κ³Όλ₯Ό κ²€μ¦ν•©λ‹ˆλ‹€. ν•Έλ“€ ID ν˜•μ‹ λ³€κ²½ μ‹œ downstream ν…ŒμŠ€νŠΈλ₯Ό κ°±μ‹ ν•˜λŠ” 지침을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

Changes

ν•Έλ“€ ID μ •μ œ 검증

Layer / File(s) Summary
μ •μ œ ν…ŒμŠ€νŠΈ 및 κ°±μ‹  μ§€μΉ¨
frontend/src/erd/handleUtils.test.ts, .jules/bolt.md
sanitizeHandleId ν…ŒμŠ€νŠΈλ₯Ό it.each 기반으둜 λ³€κ²½ν–ˆμŠ΅λ‹ˆλ‹€. 영문, 빈 λ¬Έμžμ—΄, 특수문자, μœ λ‹ˆμ½”λ“œ, 이λͺ¨μ§€, 곡백, μ œμ–΄λ¬Έμž, κ²°ν•© 문자, ZWJ 이λͺ¨μ§€λ₯Ό κ²€μ¦ν•©λ‹ˆλ‹€. ν•Έλ“€ ID ν˜•μ‹ λ³€κ²½ ν›„ downstream ν…ŒμŠ€νŠΈμ˜ mockκ³Ό assertion을 κ²€μƒ‰ν•˜κ³  μ‹€ν–‰ν•˜λ„λ‘ κΈ°λ‘ν–ˆμŠ΅λ‹ˆλ‹€.

Estimated code review effort: 2 (Simple) | ~10 minutes

πŸš₯ Pre-merge checks | βœ… 5
βœ… Passed checks (5 passed)
Check name Status Explanation
Description Check βœ… Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check βœ… Passed 제λͺ©μ€ sanitizeHandleId의 μ—£μ§€ μΌ€μ΄μŠ€ ν…ŒμŠ€νŠΈ 좔가와 μ •κ·œμ‹ μ μš©μ΄λΌλŠ” μ£Όμš” λ³€κ²½ 사항을 μ •ν™•νžˆ μ„€λͺ…ν•©λ‹ˆλ‹€.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check βœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check βœ… Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
πŸ“ Generate docstrings
  • Create stacked PR
  • Commit on current branch
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch improve-sanitize-handle-id-tests-12233152362821265480

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

πŸ€– Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@frontend/src/erd/handleUtils.test.ts`:
- Around line 6-19: Update the test cases in the sanitizeHandleId parameterized
table to expect the actual hexadecimal Unicode-scalar encoding with the c-
prefix, using src-c- and tgt-c- forms where applicable. Replace the empty-string
expectation with c-empty and revise every listed input, including the cases
referenced around lines 25–31, to match sanitizeHandleId’s returned format.
πŸͺ„ Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
βš™οΈ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b848f00b-7850-4c12-a93c-f75fd746161d

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 72afe6d and 51015ea.

πŸ“’ Files selected for processing (2)
  • .jules/bolt.md
  • frontend/src/erd/handleUtils.test.ts

Comment thread frontend/src/erd/handleUtils.test.ts

Copy link
Copy Markdown
Collaborator Author

Superseded by #786 at exact head 3cb4319c7050a4a32c464f751e837b0a23bfeedd. The unique alphanumeric, whitespace, symbol, control, combining-mark, and ZWJ encoder cases are now consolidated there beside the bounded fail-closed decoder and repeated-edge index regression. Closing this overlapping test-refactor branch to keep one canonical handle-contract lane.

@seonghobae seonghobae closed this Aug 9, 2026
@google-labs-jules

Copy link
Copy Markdown

Superseded by #786 at exact head 3cb4319c7050a4a32c464f751e837b0a23bfeedd. The unique alphanumeric, whitespace, symbol, control, combining-mark, and ZWJ encoder cases are now consolidated there beside the bounded fail-closed decoder and repeated-edge index regression. Closing this overlapping test-refactor branch to keep one canonical handle-contract lane.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant