perf(frontend): preserve search identity and isolate snapshot polling - #765
perf(frontend): preserve search identity and isolate snapshot polling#765seonghobae wants to merge 4 commits into
Conversation
|
Warning Review limit reached
Next review available in: 24 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Comment |
Buyer-visible problem
Active canvas search rebuilt decorated
node.dataobjects during high-frequency position-only updates, defeating identity-based memoization and adding avoidable allocation/GC pressure. Snapshot polling also used overlappingsetIntervalrequests, allowing an older response or rejection to overwrite state after the user selected a newer snapshot.Exact current head
b2eb0e8c2ff19faab3a44cd171cbae33eea96176The fail-first test commit is
bf8f6d4f27e41e5cd11a6cc3b4b1b7bdf50826db. No predecessor-head review or check is reused.Implemented bounded repair
TableNodeDatain a normalized-query-scopedWeakMapkeyed by the immutable source data object;setTimeoutpolling;succeeded,failed, ornot_foundwhile retaining the terminal snapshot-list refresh;CHANGELOG.mdanddocs/doctoring/search-identity-and-sequential-polling.mdwith APA 7 references and monitoring/rollback guidance.Observable regression evidence
frontend/src/App.searchPolling.test.tsxcaptures the payload passed to React Flow and proves exact reference identity withtoBe. It drives a position-only update and a source-data replacement, reverses snapshot response order, rejects a superseded request with sensitive detail, and uses controlled timers to prove that a pending request prevents overlap, a non-terminal completion schedules exactly one later request, and a terminal response shuts polling down.Exact-head checks
The exact current head has successful repository
ci,Security Scan,SAST Semgrep, and CodeRabbit status. There are no inline review threads or submitted requested-change reviews.Merge boundary
Merge only after every repository-required exact-head check remains successful, a qualifying independent non-author current-head approval exists, and branch protection accepts the unchanged head without bypass. Queued, cancelled, skipped-required, absent, stale-head, author-only, or status-only approval evidence is not accepted.
This clean replacement supersedes closed #693, whose accumulated 66-file branch could not support defensible review evidence.