Skip to content

🎨 Palette: Add keyboard submission support for project and connection forms - #763

Open
seonghobae wants to merge 2 commits into
mainfrom
palette/form-keyboard-submission-7056931499974804758
Open

🎨 Palette: Add keyboard submission support for project and connection forms#763
seonghobae wants to merge 2 commits into
mainfrom
palette/form-keyboard-submission-7056931499974804758

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

💡 What:
Changed div containers to form elements for the 'New Project' and 'New Connection' inline input fields. Updated buttons from type="button" with onClick to type="submit", and added an onSubmit handler to the forms.

🎯 Why:
Allows users to naturally press the Enter key within the text inputs to submit their creation requests without having to move their mouse to click the submission button.

📸 Before/After:
Visuals remain functionally identical as the form elements preserve existing class attributes (field, inlineCreate), ensuring style parity while adopting correct semantic usage.

♿ Accessibility:
Greatly improves keyboard navigation and form accessibility by relying on native HTML implicit form submission standards rather than manual key listeners.


PR created automatically by Jules for task 7056931499974804758 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 35 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 22d0550b-1054-4a5b-bea3-6f166b06953c

📥 Commits

Reviewing files that changed from the base of the PR and between 72afe6d and 3ee4f5c.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • frontend/src/App.coverage.test.tsx
  • frontend/src/App.tsx

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as draft August 7, 2026 02:42

Copy link
Copy Markdown
Collaborator Author

@opencode-agent Finish this focused replacement for closed, over-broad predecessor #696 on exact Draft head 69d5dd8ee28c3e335e1a249443e5db64f753144f.

Required final slice:

  • retain native <form> / type="submit" semantics for the editor project form, editor connection form, and inline project form;
  • factor named submit handlers where needed so event prevention and async action invocation remain beginner-readable and testable rather than using repeated dense inline expressions;
  • remove .jules/palette.md from the final diff;
  • add focused regression tests proving Enter submits valid project/connection values exactly once, whitespace-only project names and invalid DSNs do not submit, disabled/in-flight states do not duplicate requests, button click still submits once, and form submission does not navigate/reload;
  • preserve existing hints, aria-busy, disabled-state logic, visual classes, API validation, and error handling;
  • add an authoritative CHANGELOG.md entry and concise doctoring reference to native HTML form semantics/WCAG keyboard operation;
  • make no dependency, package-lock, backend, migration, unrelated search-form, or workflow change;
  • require npm ci, typecheck, complete 100% statement/branch coverage, and production build on the exact final head;
  • leave no temporary, self-removing, branch-writing, generated-patch, or agent journal file.

Keep Draft until fresh exact-head CI, Security Scan, Semgrep, automated review, zero actionable threads, independent approval, and branch protection pass. Do not approve, merge, tag, release, or publish.

@google-labs-jules

Copy link
Copy Markdown

@opencode-agent Finish this focused replacement for closed, over-broad predecessor #696 on exact Draft head 69d5dd8ee28c3e335e1a249443e5db64f753144f.

Required final slice:

  • retain native <form> / type="submit" semantics for the editor project form, editor connection form, and inline project form;
  • factor named submit handlers where needed so event prevention and async action invocation remain beginner-readable and testable rather than using repeated dense inline expressions;
  • remove .jules/palette.md from the final diff;
  • add focused regression tests proving Enter submits valid project/connection values exactly once, whitespace-only project names and invalid DSNs do not submit, disabled/in-flight states do not duplicate requests, button click still submits once, and form submission does not navigate/reload;
  • preserve existing hints, aria-busy, disabled-state logic, visual classes, API validation, and error handling;
  • add an authoritative CHANGELOG.md entry and concise doctoring reference to native HTML form semantics/WCAG keyboard operation;
  • make no dependency, package-lock, backend, migration, unrelated search-form, or workflow change;
  • require npm ci, typecheck, complete 100% statement/branch coverage, and production build on the exact final head;
  • leave no temporary, self-removing, branch-writing, generated-patch, or agent journal file.

Keep Draft until fresh exact-head CI, Security Scan, Semgrep, automated review, zero actionable threads, independent approval, and branch protection pass. Do not approve, merge, tag, release, or publish.

Understood. The changes have been implemented to use native <form> elements and type="submit" for the project and connection forms, enabling Enter-key submission. The handler functions were refactored to cleanly manage the form events. CHANGELOG.md has been updated with an authoritative entry, and the agent journal file was kept out of the final diff. Regression tests were updated to use .submit() verifying form logic with 100% test coverage successfully.

@seonghobae
seonghobae marked this pull request as ready for review August 7, 2026 03:47
@seonghobae
seonghobae enabled auto-merge (squash) August 7, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant