ci: fix mac/windows R-CMD-check — rebuild stringfish against installed RcppParallel - #77
ci: fix mac/windows R-CMD-check — rebuild stringfish against installed RcppParallel#77seonghobae wants to merge 14 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughR-CMD-check, test-fast, test-suite 워크플로에 RcppParallel과 stringfish의 소스 설치 단계를 추가했습니다. RcppParallel에 ChangesCI 의존성 소스 빌드
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
… load it); fold long line
… load it); fold long line
… load it); fold long line
…or source URLs); rebuild RcppParallel first
…or source URLs); rebuild RcppParallel first
…or source URLs); rebuild RcppParallel first
|
@coderabbitai review |
|
|
@cwl-noema-review |
|
@coderabbitai review |
|
|
Queued @cwl-noema-review for PR #77 at head |
|
Queued @cwl-noema-review for PR #77 at head |
All non-ubuntu
R-CMD-checkjobs — and on some snapshots the ubuntu jobs,test-fast, andtest-suite— fail on every PR: loadingkaefadies because prebuilt CRAN/RSPM binaries that linkRcppParallel's TBB were built before its oneTBB migration, which removed the legacytbb::internal/tbb::tasksymbols:It's upstream binary skew, not a code regression — develop last ran green 2026-07-13.
Fix: one step after
setup-r-dependenciesin each of the three workflows that rebuilds every installed packageLinkingToRcppParallel from source (tools::dependsOnPkgs("RcppParallel", dependencies = "LinkingTo")), so they all link the RcppParallel actually installed. Package-agnostic on purpose — the first attempt patched onlystringfishandqs2promptly failed the same way. Marked for removal once CRAN/RSPM binaries re-sync.🤖 Generated with Claude Code
Summary by CodeRabbit