Skip to content

ci: fix mac/windows R-CMD-check — rebuild stringfish against installed RcppParallel - #77

Open
seonghobae wants to merge 14 commits into
developfrom
ci/rebuild-stringfish-abi
Open

ci: fix mac/windows R-CMD-check — rebuild stringfish against installed RcppParallel#77
seonghobae wants to merge 14 commits into
developfrom
ci/rebuild-stringfish-abi

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

All non-ubuntu R-CMD-check jobs — and on some snapshots the ubuntu jobs, test-fast, and test-suite — fail on every PR: loading kaefa dies because prebuilt CRAN/RSPM binaries that link RcppParallel's TBB were built before its oneTBB migration, which removed the legacy tbb::internal/tbb::task symbols:

stringfish.so: Symbol not found: __ZN3tbb8internal12NFS_AllocateEmmPv          (macOS)
stringfish.so: undefined symbol: _ZN3tbb8internal25concurrent_vector_base_...  (ubuntu)
qs2.so:        Symbol not found: __ZN3tbb4task13note_affinityEt                (macOS, after fixing stringfish)

It's upstream binary skew, not a code regression — develop last ran green 2026-07-13.

Fix: one step after setup-r-dependencies in each of the three workflows that rebuilds every installed package LinkingTo RcppParallel from source (tools::dependsOnPkgs("RcppParallel", dependencies = "LinkingTo")), so they all link the RcppParallel actually installed. Package-agnostic on purpose — the first attempt patched only stringfish and qs2 promptly failed the same way. Marked for removal once CRAN/RSPM binaries re-sync.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • 테스트
    • 다양한 환경에서 패키지 설치와 빌드 검증이 보다 안정적으로 수행되도록 자동화된 검사 절차를 개선했습니다.
    • 관련 패키지를 소스에서 다시 빌드하는 검증 단계를 추가해 호환성 문제를 조기에 확인할 수 있습니다.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c8aa5b0d-8c24-435b-8a54-90099f4c4d68

📥 Commits

Reviewing files that changed from the base of the PR and between 5128d48 and 810dfa0.

📒 Files selected for processing (3)
  • .github/workflows/R-CMD-check.yaml
  • .github/workflows/test-fast.yaml
  • .github/workflows/test-suite.yaml

📝 Walkthrough

Walkthrough

R-CMD-check, test-fast, test-suite 워크플로에 RcppParallel과 stringfish의 소스 설치 단계를 추가했습니다. RcppParallel에 LinkingTo로 의존하는 패키지도 탐지하여 소스에서 재빌드합니다.

Changes

CI 의존성 소스 빌드

Layer / File(s) Summary
소스 패키지 설치
.github/workflows/R-CMD-check.yaml, .github/workflows/test-fast.yaml, .github/workflows/test-suite.yaml
세 워크플로가 일반 의존성 설정 전에 RcppParallelstringfish를 CRAN 소스에서 설치합니다.
LinkingTo 패키지 재빌드
.github/workflows/R-CMD-check.yaml, .github/workflows/test-fast.yaml, .github/workflows/test-suite.yaml
세 워크플로가 RcppParallelLinkingTo로 의존하는 패키지를 검색하고 소스에서 재설치합니다.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested reviewers: copilot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 RcppParallel에 맞춘 stringfish 재빌드와 CI 수정이라는 주요 변경 사항을 구체적으로 설명합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/rebuild-stringfish-abi

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown
Collaborator Author

@opencode-agent

Copy link
Copy Markdown
Collaborator Author

@cwl-noema-review

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@opencode-agent

opencode-agent Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Queued @cwl-noema-review for PR #77 at head fbba747eaf1399613c7faf5b9332d3f5a1b557a3. Central exact-name Actions artifacts are the durable dispatch ledger; existing review workflows remain authoritative for the final verdict and failure evidence.

@opencode-agent

opencode-agent Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Queued @cwl-noema-review for PR #77 at head 810dfa0466b920cabc617f9be6817ab46d2e3b00. Central exact-name Actions artifacts are the durable dispatch ledger; existing review workflows remain authoritative for the final verdict and failure evidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant