Skip to content

perf: reuse file-name comparator - #420

Merged
seonghobae merged 2 commits into
masterfrom
perf/hoist-file-name-comparator-current
Aug 11, 2026
Merged

perf: reuse file-name comparator#420
seonghobae merged 2 commits into
masterfrom
perf/hoist-file-name-comparator-current

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Problem

PR #404 isolates a valid allocation reduction, but its branch diverged from current protected master and is now conflicted. Reusing that stale branch would transfer obsolete base state and predecessor evidence.

Current-base reconstruction

This successor rebuilds only the unique semantic delta on protected master@119846f7eb519fd4091fccf5429fa2cc43f502a2:

  • create one immutable FILE_NAME_COMPARATOR;
  • reuse it in the existing process_dir sort;
  • preserve filename ordering, directory traversal, metadata checks, and sensitive-file filtering;
  • record the bounded optimization without claiming an unmeasured throughput gain.

Supersedes #404 and preserves lineage to the earlier duplicate #174. No workflow, dependency, API, or security-boundary change is included.

Acceptance boundary

Merge only after exact-head CI, coverage, security, current-head review, and live repository policy succeed with zero valid unresolved findings.

Summary by CodeRabbit

  • 성능 개선
    • 디렉터리 내 파일 정렬 처리에서 비교 로직을 재사용하도록 최적화했습니다.
    • 기존과 동일한 파일명 정렬 순서와 파일 시스템 동작을 유지합니다.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4c278a27-da8f-4df8-9393-a08c4b36f589

📥 Commits

Reviewing files that changed from the base of the PR and between 119846f and 051036c.

📒 Files selected for processing (2)
  • .jules/bolt.md
  • src/main/kotlin/html4tree/main.kt

📝 Walkthrough

Walkthrough

파일명 비교자를 최상위 불변 값으로 추출했습니다. process_dir는 디렉터리 파일 정렬에 해당 비교자를 재사용합니다. 정렬 순서는 유지됩니다.

Changes

파일명 비교자 재사용

Layer / File(s) Summary
비교자 정의 및 디렉터리 정렬 적용
src/main/kotlin/html4tree/main.kt, .jules/bolt.md
FILE_NAME_COMPARATOR를 추가했습니다. process_dir는 인라인 비교자 대신 해당 비교자를 사용합니다. 변경 내용을 .jules/bolt.md에 기록했습니다.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 파일명 비교자 재사용이라는 주요 변경 사항을 정확하고 간결하게 설명합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch perf/hoist-file-name-comparator-current

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae merged commit 187449c into master Aug 11, 2026
27 checks passed
@seonghobae
seonghobae deleted the perf/hoist-file-name-comparator-current branch August 11, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant