Skip to content

🎨 Palette: λΉ„ν™œμ„±ν™”λœ λ²„νŠΌμ˜ 툴팁 μ ‘κ·Όμ„± κ°œμ„  #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 4 commits into from
Closed

🎨 Palette: λΉ„ν™œμ„±ν™”λœ λ²„νŠΌμ˜ 툴팁 μ ‘κ·Όμ„± κ°œμ„  #778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
11afbd9
🎨 Palette: λΉ„ν™œμ„±ν™”λœ λ²„νŠΌμ˜ 툴팁 μ ‘κ·Όμ„± κ°œμ„ 
seonghobae Aug 6, 2026
459498e
🎨 Palette: λΉ„ν™œμ„±ν™”λœ λ²„νŠΌμ˜ 툴팁 μ ‘κ·Όμ„± κ°œμ„ 
seonghobae Aug 6, 2026
2a69abc
🎨 Palette: λΉ„ν™œμ„±ν™”λœ λ²„νŠΌμ˜ 툴팁 μ ‘κ·Όμ„± κ°œμ„ 
seonghobae Aug 6, 2026
6205927
🎨 Palette: λΉ„ν™œμ„±ν™”λœ λ²„νŠΌμ˜ 툴팁 μ ‘κ·Όμ„± κ°œμ„ 
seonghobae Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/desktop/src/features/score/ScoreView.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ describe("ScoreView", () => {

expect(screen.getByText("Scores attach to the active analysis project.")).toBeInTheDocument();
expect(screen.getByRole("button", { name: "Add score" })).toBeDisabled();
expect(screen.getByRole("button", { name: "Open score: opener.pdf" })).toBeDisabled();
expect(screen.getByRole("button", { name: "Open score: opener.pdf" })).toHaveAttribute("aria-disabled", "true");
expect(screen.getByRole("button", { name: "Remove: opener.pdf" })).toBeDisabled();

fireEvent.click(screen.getByRole("button", { name: "Open score: opener.pdf" }));
Expand Down
5 changes: 3 additions & 2 deletions apps/desktop/src/features/score/ScoreView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,10 +184,11 @@ export function ScoreView({ song, projectId, onSongUpdate }: ScoreViewProps) {
<button
type="button"
onClick={projectId ? () => void openAttachment(projectId, attachment) : undefined}
disabled={!projectId}
aria-disabled={!projectId ? "true" : undefined}
title={!projectId ? t("scoreRequiresProject") : undefined}
aria-current={selected?.id === attachment.id ? "true" : undefined}
aria-label={`${t("scoreOpen")}: ${attachment.fileName}`}
className="flex min-h-10 min-w-0 flex-1 items-center gap-2 text-left text-sm font-semibold text-slate-100 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-cyan-300 disabled:cursor-not-allowed disabled:opacity-60"
className="flex min-h-10 min-w-0 flex-1 items-center gap-2 text-left text-sm font-semibold text-slate-100 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-cyan-300 aria-disabled:cursor-not-allowed aria-disabled:opacity-60"
>
<FileMusic className="size-4 shrink-0 text-cyan-300" aria-hidden="true" />
<span className="truncate">{attachment.fileName}</span>
Expand Down
32 changes: 3 additions & 29 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
},
"overrides": {
"brace-expansion": "5.0.9",
"postcss": "8.5.25"
"postcss": "8.5.25",
"undici": "^7.29.0"
}
}
Loading