ci(release): converge on the shared release.yml - #136
Merged
Conversation
Replaces the per-channel release callers with a single release.yml that calls ConductionNL/.github/.github/workflows/release.yml@main for all three channels. Removed: release-beta.yml release-stable.yml
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
August 18, 2026 15:16
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 525/525 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-18 15:38 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One
.github/workflows/release.ymlreplaces this repo's per-channel release callers. It calls the sharedConductionNL/.github/.github/workflows/release.yml@mainfor all three channels:unstabledevelopmentunstablebetabetabetastablemainstableDeleted:
release-beta.yml,release-stable.ymlWhy
The old
release-beta.yml/release-stable.ymlpair editsappinfo/info.xmlin the working tree only and never commits it, so the tag it cuts names a commit that still shows the previous version. Nextcloud's own release template assertswhich is simply wrong for a stable release, and harmless only for timestamped dev builds.
The shared
release.ymlcommits the bump to arelease/v<version>branch, tags that commit, and opens a pull request to bring the integration branch up — so the tag and the packaged tarball agree, without anything pushing at a protected branch. That PR routing is what ConductionNL/.github#502 added.Behaviour change
release-development.yml, so it has never published an unstable build. The converged workflow adds anunstablejob that fires on every push todevelopment, publishing a GitHub prerelease with a.tar.gz(never uploaded to the Nextcloud app store — the shared workflow skips that step for this channel). Beta and stable are unchanged in when they fire. This is an addition of behaviour, not a conversion — flagging it rather than letting it hide in the diff.Verified on this branch
release.ymlparses as YAML; exactly three jobs,unstable/beta/stable, all pointing atConductionNL/.github/.github/workflows/release.yml@mainapp-namematches<id>inappinfo/info.xmlcompare development...touches only.github/workflows/release*.yml