check_files: make patterns apply to the directory names#421
Open
inqrphl wants to merge 2 commits into
Open
Conversation
previously the files would be selectively added matching the pattern with their filenames, and directories which did not contain any of those files were removed from entryList now remove all directories completely when pattern is used
previously, pattersns only applied to file names. afterwards, directories that did not contain any matching files were removed now, the patterns apply directly to the directories as well. no futher processing for directories are done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously, pattersns only applied to file names. afterwards, directories that did not contain any matching files under them were removed
now, the patterns apply directly to the directories as well. no further processing for directories are done
question: should I completely remove removeDirectoriesWithoutFilesUnder() function now?
a user could theoretically use a filter like this:
filter="(type eq 'file' and name like '*.log') or (type eq 'dir')"
Without removeDirectoriesWithoutFilesUnder , he would see every directory. With removeDirectoriesWithoutFilesUnder , he would only see directories that contain a log file under them.