Skip to content

fix MSI upgrade hanging due to service not stopped before file removal #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
inqrphl wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

fix MSI upgrade hanging due to service not stopped before file removal #415

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
114ac3f
ai commit: fix MSI upgrade hanging due to service not stopped before …
inqrphl Jul 15, 2026
c1c2952
ai commit: remove After="InstallInitialize" direftive in CustomPreUpd…
inqrphl Jul 15, 2026
89b425a
ai commit: Fix MSI upgrade hanging due to service not stopped before …
inqrphl Jul 16, 2026
92ea605
ai commit: Fix MSI upgrade: stop service before RemoveExistingProducts
inqrphl Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packaging/windows/snclient.wxs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<Wix xmlns="http://schemas.microsoft.com/wix/2006/wi">
<Product Name="SNClient" Id="*" UpgradeCode="F4BF03F6-D3DA-44FF-A444-9B64119DA0CE" Language="1033" Codepage="1252" Version="$(var.MajorVersion).$(var.MinorVersion).$(var.RevisionNumber)" Manufacturer="ConSol Consulting and Solutions Software GmbH">
<Package InstallScope="perMachine" InstallerVersion="$(var.InstallerVersion)" Compressed="yes" />
<MajorUpgrade AllowSameVersionUpgrades="yes" DowngradeErrorMessage="A newer version of [ProductName] is already installed. It must be uninstalled for downgrades." />
<MajorUpgrade AllowSameVersionUpgrades="yes" Schedule="afterInstallInitialize" DowngradeErrorMessage="A newer version of [ProductName] is already installed. It must be uninstalled for downgrades." />
<Property Id="REBOOT" Value="ReallySuppress" />
<Property Id="MSIRESTARTMANAGERCONTROL" Value="Disable" />
<Property Id="WIXUI_INSTALLDIR" Value="INSTALLDIR" />
Expand Down Expand Up @@ -99,7 +99,7 @@
<SetProperty Id="CustomUnInstallerAction" Sequence="execute" Before="CustomUnInstallerAction" Value="&quot;[INSTALLDIR]snclient.exe&quot; uninstall pkg &quot;INSTALLDIR=[INSTALLDIR]; WIX_UPGRADE_DETECTED=[WIX_UPGRADE_DETECTED]; REMOVE=[REMOVE]; UPGRADINGPRODUCTCODE=[UPGRADINGPRODUCTCODE]&quot;" />
<CustomAction Id="CustomUnInstallerAction" BinaryKey="WixCA" DllEntry="WixQuietExec" Execute="deferred" Return="ignore" Impersonate="no" />
<InstallExecuteSequence>
<Custom Action="CustomPreUpdateAction" After="InstallInitialize"></Custom>
<Custom Action="CustomPreUpdateAction" Before="RemoveExistingProducts"></Custom>
<Custom Action="CustomUnInstallerAction" Before="RemoveFiles"><![CDATA[REMOVE ~= "ALL" AND (NOT UPGRADINGPRODUCTCODE)]]></Custom>
<Custom Action="CustomInstallerAction" Before="InstallFinalize"></Custom>
</InstallExecuteSequence>
Expand Down
Loading