CMP-4440: Add manual rule kubevirt-restrict-cross-datavolume-cloning (CIS OCP-Virt 3.1) - #14940
Conversation
|
Hi @taimurhafeez. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
LGTM — placeholders render correctly in the ocil. One ask: rebase to drop the duplicated build-script/docs change once #14920 merges. |
rhmdnd
left a comment
rhmdnd
left a comment
There was a problem hiding this comment.
We're on the right track, just need a rebase and an update to the description pointing users to CustomRules as a way to automate this check.
| ClusterRole to service accounts in other namespaces. Unrestricted | ||
| cross-namespace cloning allows subjects to copy virtual machine | ||
| disk data from one namespace to another, potentially exposing | ||
| sensitive workload data to unauthorized tenants. |
There was a problem hiding this comment.
We discussed manual rules with the team. The consensus is that manual rules serve as signals for customers to create their own CustomRules that replace the manual check with an environment-specific automated check.
We can update the description to make this more apparent:
Because the set of authorized subjects and namespaces is specific to each
cluster, this rule cannot be evaluated automatically and is reported as
manual. Organizations can create a CustomRule with a CEL expression that
lists RoleBindings referencing the <tt>datavolume-cloner</tt> ClusterRole
and verifies that only approved subjects and destination namespaces are
bound.
…(CIS OCP-Virt 3.1)
…iption that explains manual status and points organizations to CustomRules for automation. Co-Authored-By: Claude Opus 4.6
ee380d9 to
277011f
Compare
openshift-ci
Bot
added
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
Add a manual rule for CIS OCP-Virt control 3.1 "Restrict access to cross DataVolume cloning". The rule documents the audit procedure for reviewing rolebindings that grant cross-namespace datavolume-cloner permissions, and is added to the cis-vm-extension CEL profile. Also relax build_cel_content.py to warn instead of error when a CEL profile references rules without CEL checks, allowing manual rules in CEL profiles. Update CEL documentation accordingly.
Co-Authored-By: Claude