Rate statistic - #120
Conversation
alexeid
left a comment
There was a problem hiding this comment.
Looks okay. I understand this it to make RateStatistic a RealVector? But when is that actually needed? It just goes into a logger normally doesn't it? So it can still be a function since loggers aren't part of the model and strong typing only needs to be enforced for model components?
Because it uses a deprecated class, which was replaced by strong typing when tracing the inheritance chain. In addition, I presume |
|
Removing the old RateStatistic means old XML cannot run any more. |
the old (deprecated) RateStatistic would not be removed, unless |
migrate RateStatistic and update xml, module-info, and version.xml.
see #119