Skip to content

Rate statistic - #120

Open
walterxie wants to merge 2 commits into
masterfrom
RateStatistic
Open

Rate statistic#120
walterxie wants to merge 2 commits into
masterfrom
RateStatistic

Conversation

@walterxie

Copy link
Copy Markdown
Member

migrate RateStatistic and update xml, module-info, and version.xml.

see #119

@walterxie
walterxie requested review from alexeid and rbouckaert July 20, 2026 23:18

@alexeid alexeid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. I understand this it to make RateStatistic a RealVector? But when is that actually needed? It just goes into a logger normally doesn't it? So it can still be a function since loggers aren't part of the model and strong typing only needs to be enforced for model components?

@walterxie

walterxie commented Jul 21, 2026

Copy link
Copy Markdown
Member Author

Looks okay. I understand this it to make RateStatistic a RealVector? But when is that actually needed? It just goes into a logger normally doesn't it? So it can still be a function since loggers aren't part of the model and strong typing only needs to be enforced for model components?

Because it uses a deprecated class, which was replaced by strong typing when tracing the inheritance chain. In addition, I presume Function will be removed in future with all deprecated classes.

@rbouckaert

Copy link
Copy Markdown
Member

Removing the old RateStatistic means old XML cannot run any more.

@walterxie

Copy link
Copy Markdown
Member Author

Removing the old RateStatistic means old XML cannot run any more.

the old (deprecated) RateStatistic would not be removed, unless Function is removed as well as all deprecated classes using old Parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants